chromeos/dbus/debug_daemon_client.cc - Issue 176693003: chromeos: Make dbus::MessageReader memory ownership explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 176693003: chromeos: Make dbus::MessageReader memory ownership explicit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update a few more callers Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/debug_daemon_client.cc

diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc

index 9d06e5f721003de08cbca3428d8f33965f30a0a8..2f24e94105d9bb8d7a8bb266de05348d5047b8b3 100644

--- a/chromeos/dbus/debug_daemon_client.cc

+++ b/chromeos/dbus/debug_daemon_client.cc

@@ -514,10 +514,10 @@ class DebugDaemonClientImpl : public DebugDaemonClient {

}

dbus::MessageReader reader(response);

- uint8* buffer = NULL;

+ const uint8* buffer = NULL;

size_t buf_size = 0;

- if (!reader.PopArrayOfBytes(reinterpret_cast<uint8**>(

- &buffer), &buf_size)) {

+ if (!reader.PopArrayOfBytes(reinterpret_cast<const uint8**>(&buffer),

satorux1 2014/02/24 07:44:55 reinterpret_cast<> looks unnecessary?

Daniel Erat 2014/02/24 08:16:17 good catch; i'm not sure why it was there in the f

+ &buf_size)) {

return;

}

« no previous file with comments | « chromeos/dbus/cryptohome_client.cc ('k') | chromeos/dbus/session_manager_client.cc » ('j') | no next file with comments »