chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc - Issue 176693003: chromeos: Make dbus::MessageReader memory ownership explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 176693003: chromeos: Make dbus::MessageReader memory ownership explicit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update a few more callers Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | chromeos/dbus/debug_daemon_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

index f425e33ccaae600303ec10267cadc71794775391..438663c8034752c530288eed8f33ea25850de77b 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

@@ -420,7 +420,7 @@ dbus::Response* NativeBackendKWalletTest::KWalletMethodCall(

int handle = NativeBackendKWalletStub::kInvalidKWalletHandle;

std::string folder_name;

std::string key;

- uint8_t* bytes = NULL;

+ const uint8_t* bytes = NULL;

size_t length = 0;

std::string app_name;

EXPECT_TRUE(reader.PopInt32(&handle));

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | chromeos/dbus/debug_daemon_client.cc » ('J')