chromeos: Make dbus::MessageReader memory ownership explicit

chromeos/dbus/debug_daemon_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/debug_daemon_client.h"
 
 #include <fcntl.h>
 #include <unistd.h>
 #include <string>
 #include <vector>
@@ skipping 496 matching lines @@
 
   void OnGetPerfData(const GetPerfDataCallback& callback,
                      dbus::Response* response) {
     std::vector<uint8> data;
 
     if (!response) {
       return;
     }
 
     dbus::MessageReader reader(response);
-    uint8* buffer = NULL;
+    const uint8* buffer = NULL;
     size_t buf_size = 0;
-    if (!reader.PopArrayOfBytes(reinterpret_cast<uint8**>(
-        &buffer), &buf_size)) {
+    if (!reader.PopArrayOfBytes(reinterpret_cast<const uint8**>(&buffer),

[satorux1, 2014/02/24 07:44:55]

reinterpret_cast<> looks unnecessary?

[Daniel Erat, 2014/02/24 08:16:17]

good catch; i'm not sure why it was there in the first place

+                                &buf_size)) {
       return;
     }
 
     // TODO(asharif): Figure out a way to avoid this copy.
     data.insert(data.end(), buffer, buffer + buf_size);
 
     callback.Run(data);
   }
 
   void OnGetAllLogs(const GetLogsCallback& callback,
@@ skipping 100 matching lines @@
 DebugDaemonClient::EmptyStopSystemTracingCallback() {
   return base::Bind(&EmptyStopSystemTracingCallbackBody);
 }
 
 // static
 DebugDaemonClient* DebugDaemonClient::Create() {
   return new DebugDaemonClientImpl();
 }
 
 }  // namespace chromeos