Collect failed "target"s from ninja in the compile step on Waterfall.

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
@@ skipping 148 matching lines @@
       '--gsutil-py-path', self.m.depot_tools.gsutil_py_path,
       '--ninja-path', self.m.depot_tools.ninja_path,
       '--target', target or self.c.build_config_fs,
       '--src-dir', self.m.path['checkout'],
       '--goma-cache-dir', self.m.path['goma_cache'],
     ]
     if self.c.compile_py.build_args:
       args += ['--build-args', self.c.compile_py.build_args]
     if self.c.compile_py.build_tool:
       args += ['--build-tool', self.c.compile_py.build_tool]
+      if self.c.compile_py.build_tool == 'ninja':
+        # Collect info of compile failure from ninja 1.7+.
+        args += [
+          '--ninja-compile-failure',
+          self.m.json.output(add_json_log=False, name='ninja-compile-failure')]
     if self.m.properties.get('build_data_dir'):
       args += ['--build-data-dir', self.m.properties.get('build_data_dir')]
     if self.c.compile_py.cross_tool:
       args += ['--crosstool', self.c.compile_py.cross_tool]
     if self.c.compile_py.compiler:
       args += ['--compiler', self.c.compile_py.compiler]
       if 'goma' in self.c.compile_py.compiler:
         args += [
             '--goma-jsonstatus', self.m.json.output(),
         ]
@@ skipping 68 matching lines @@
         if failure_result_code:
           # Mark goma setup failure as exception instead of step failure.
           step_result.presentation.status = self.m.step.EXCEPTION
           assert len(failure_result_code) <= 20
           properties = self.m.step.active_result.presentation.properties
           if not properties.get('extra_result_code'):
             properties['extra_result_code'] = []
           properties['extra_result_code'].append(failure_result_code)
           raise self.m.step.InfraFailure('Infra compile failure: %s' % e)
 
+      if self.c.compile_py.build_tool == 'ninja':
+        # Report failed compile "target"s from ninja as a build property so that
+        # automated tools/service like Findit could use them for the purpose of
+        # culprit finding, etc.
+        # When there is an infra failure like goma outage above, no info is
+        # collected from ninja.
+        step_result = self.m.step.active_result
+        failures = (step_result.json.outputs['ninja-compile-failure'] or
+                    {'unknown_failures': True})
+        step_result.presentation.properties['compile_failures'] = failures
+
       raise e
 
   @recipe_util.returns_placeholder
   def test_launcher_filter(self, tests):
     return TestLauncherFilterFileInputPlaceholder(self, tests)
 
   def runtest(self, test, args=None, xvfb=False, name=None, annotate=None,
               results_url=None, perf_dashboard_id=None, test_type=None,
               python_mode=False, spawn_dbus=True, parallel=False,
               revision=None, webkit_revision=None,
@@ skipping 443 matching lines @@
       }))
 
   def get_annotate_by_test_name(self, test_name):
     return 'graphing'
 
   def download_lto_plugin(self):
     return self.m.python(
         name='download LTO plugin',
         script=self.m.path['checkout'].join(
             'build', 'download_gold_plugin.py'))