Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1766833002: - Remove loading of observatory assets from dart_bootstrap. (Closed)

Created:
4 years, 9 months ago by Ivan Posva
Modified:
4 years, 9 months ago
Reviewers:
Bill Hesse, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Remove loading of observatory assets from dart_bootstrap. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9535aa642621f0d44af6592ef0530e68e6762de4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M runtime/bin/bin.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 6 chunks +15 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 9 months ago (2016-03-04 22:36:42 UTC) #2
rmacnak
lgtm
4 years, 9 months ago (2016-03-04 23:43:26 UTC) #3
Ivan Posva
4 years, 9 months ago (2016-03-05 00:05:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9535aa642621f0d44af6592ef0530e68e6762de4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698