Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1766823002: Revert "Add option to GYP to use chromium clang plugins." (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add option to GYP to use chromium clang plugins." This reverts commit 44beca7313284a60c21b4973d42f993b8c248ec9. Reason: broken build on chromium bots. R=ochang@chromium.org TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5ad8474335798295a9c502999324635845d28ff7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M pdfium.gyp View 3 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
See http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/166444
4 years, 9 months ago (2016-03-04 21:58:22 UTC) #2
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-04 21:58:46 UTC) #4
Tom Sepez
Committed patchset #1 (id:1) manually as 5ad8474335798295a9c502999324635845d28ff7 (presubmit successful).
4 years, 9 months ago (2016-03-04 21:58:56 UTC) #6
dsinclair
4 years, 9 months ago (2016-03-05 14:09:24 UTC) #7
Message was sent while issue was closed. 
On 2016/03/04 21:58:56, Tom Sepez wrote:
> Committed patchset #1 (id:1) manually as
> 5ad8474335798295a9c502999324635845d28ff7 (presubmit successful).


Did it break a bunch of the bots, or just that one bot?

Powered by Google App Engine
This is Rietveld 408576698