include/effects/SkOffsetImageFilter.h - Issue 1766743003: Switch SkOffsetImageFilter over to new onFilterImage interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkOffsetImageFilter.h

Issue 1766743003: Switch SkOffsetImageFilter over to new onFilterImage interface (Closed) Base URL: https://skia.googlesource.com/skia.git@if-follow-on

Patch Set: Address code review issues Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkOffsetImageFilter.h

diff --git a/include/effects/SkOffsetImageFilter.h b/include/effects/SkOffsetImageFilter.h

index 04b896a956d36ad2130f8b684205c16c47c900a5..82d7c1f9f7df890c77ccdd59a800beb22841630f 100644

--- a/include/effects/SkOffsetImageFilter.h

+++ b/include/effects/SkOffsetImageFilter.h

@@ -28,8 +28,8 @@ public:

protected:

void flatten(SkWriteBuffer&) const override;

- bool onFilterImageDeprecated(Proxy*, const SkBitmap& src, const Context&, SkBitmap* result,

- SkIPoint* loc) const override;

+ SkSpecialImage* onFilterImage(SkSpecialImage* src, const Context&,

Stephen White 2016/03/08 15:02:27 Nit: src -> source.

robertphillips 2016/03/08 15:26:08 Done.

+ SkIPoint* offset) const override;

void onFilterNodeBounds(const SkIRect&, const SkMatrix&, SkIRect*, MapDirection) const override;

private:

« no previous file with comments | « no previous file | src/effects/SkOffsetImageFilter.cpp » ('j') | no next file with comments »