Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1766743003:
Switch SkOffsetImageFilter over to new onFilterImage interface (Closed)
|
Created:
4 years, 9 months ago by robertphillips Modified:
4 years, 9 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@if-follow-on Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSwitch SkOffsetImageFilter over to new onFilterImage interface
This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated)
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766743003
Committed: https://skia.googlesource.com/skia/+/c80bf74bccc32da1b528e667bc4970069d2a6652
Patch Set 1 #
Total comments: 4
Patch Set 2 : update to ToT #Patch Set 3 : Address code review issues #
Total comments: 2
Patch Set 4 : Add comment #Patch Set 5 : Fix name in header #Patch Set 6 : Fix bogus return value #Messages
Total messages: 27 (14 generated)
Description was changed from ========== Switch SkOffsetImageFilter over to new onFilterImage interface ========== to ========== Switch SkOffsetImageFilter over to new onFilterImage interface GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Switch SkOffsetImageFilter over to new onFilterImage interface GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Switch SkOffsetImageFilter over to new onFilterImage interface This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + senorblanco@chromium.org, senorblanco@google.com
https://codereview.chromium.org/1766743003/diff/1/src/effects/SkOffsetImageFi... File src/effects/SkOffsetImageFilter.cpp (right): https://codereview.chromium.org/1766743003/diff/1/src/effects/SkOffsetImageFi... src/effects/SkOffsetImageFilter.cpp:36: SkIRect srcBounds = SkIRect::MakeWH(srcIn->width(), srcIn->height()); I don't think this is correct. I think we should be using src's width and height here, not srcIn's. Also, let's standardize on calling the passed-in parameter "source" (instead of srcIn or src), and the local variable "input" (instead of src), since it's the input to this node. https://codereview.chromium.org/1766743003/diff/1/src/effects/SkOffsetImageFi... src/effects/SkOffsetImageFilter.cpp:52: canvas->clear(0x0); It seems surprising to me that we always have to clear the canvas where we didn't before. Isn't this implicit in surface creation or something?
https://codereview.chromium.org/1766743003/diff/1/src/effects/SkOffsetImageFi... File src/effects/SkOffsetImageFilter.cpp (right): https://codereview.chromium.org/1766743003/diff/1/src/effects/SkOffsetImageFi... src/effects/SkOffsetImageFilter.cpp:36: SkIRect srcBounds = SkIRect::MakeWH(srcIn->width(), srcIn->height()); On 2016/03/07 18:52:04, Stephen White wrote: > I don't think this is correct. I think we should be using src's width and height > here, not srcIn's. > > Also, let's standardize on calling the passed-in parameter "source" (instead of > srcIn or src), and the local variable "input" (instead of src), since it's the > input to this node. Done. https://codereview.chromium.org/1766743003/diff/1/src/effects/SkOffsetImageFi... src/effects/SkOffsetImageFilter.cpp:52: canvas->clear(0x0); The SkDevice used to do it for us. Hopefully we can exploit it being broken out now in some of the effects that don't need it.
LGTM w/nit https://codereview.chromium.org/1766743003/diff/40001/include/effects/SkOffse... File include/effects/SkOffsetImageFilter.h (right): https://codereview.chromium.org/1766743003/diff/40001/include/effects/SkOffse... include/effects/SkOffsetImageFilter.h:31: SkSpecialImage* onFilterImage(SkSpecialImage* src, const Context&, Nit: src -> source.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766743003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766743003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
https://codereview.chromium.org/1766743003/diff/40001/include/effects/SkOffse... File include/effects/SkOffsetImageFilter.h (right): https://codereview.chromium.org/1766743003/diff/40001/include/effects/SkOffse... include/effects/SkOffsetImageFilter.h:31: SkSpecialImage* onFilterImage(SkSpecialImage* src, const Context&, On 2016/03/08 15:02:27, Stephen White wrote: > Nit: src -> source. Done.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766743003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766743003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/1766743003/#ps100001 (title: "Fix bogus return value")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766743003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766743003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Switch SkOffsetImageFilter over to new onFilterImage interface This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Switch SkOffsetImageFilter over to new onFilterImage interface This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766743003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766743003/100001
Message was sent while issue was closed.
Description was changed from ========== Switch SkOffsetImageFilter over to new onFilterImage interface This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Switch SkOffsetImageFilter over to new onFilterImage interface This CL relies on: https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c80bf74bccc32da1b528e667bc4970069d2a6652 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/c80bf74bccc32da1b528e667bc4970069d2a6652 |
