Chromium Code Reviews

Issue 1766683002: Revert of Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
haraken, Primiano Tucci (use gerrit), hajimehoshi
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews-css, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing (patchset #6 id:100001 of https://codereview.chromium.org/1721333002/ ) Reason for revert: Broke official builds unfortunately, https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/45960 Original issue's description: > Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing > > BlinkGC allocation hooks for the memory infra were added at > crrev.com/1676973002, but those were not enough. This CL adds missing > hooks. > > BUG=588123 > > Committed: https://crrev.com/abd5af497f0a6f38c57f071a187b9484a0e3f306 > Cr-Commit-Position: refs/heads/master@{#379252} TBR=haraken@chromium.org,primiano@chromium.org,hajimehoshi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588123

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+25 lines, -20 lines)
M third_party/WebKit/Source/core/css/CSSValue.h View 1 chunk +1 line, -2 lines 0 comments
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -2 lines 0 comments
M third_party/WebKit/Source/platform/heap/Heap.h View 4 chunks +20 lines, -9 lines 0 comments
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 2 chunks +2 lines, -5 lines 0 comments
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +1 line, -2 lines 0 comments

Messages

Total messages: 4 (1 generated)
sof
Created Revert of Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing
4 years, 9 months ago (2016-03-04 10:35:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766683002/1
4 years, 9 months ago (2016-03-04 10:35:10 UTC) #2
haraken
4 years, 9 months ago (2016-03-04 10:40:33 UTC) #4 
LGTM

Powered by Google App Engine