Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 176663002: NaCl documentation: add links for x86-{32,64} and MIPS32. (Closed)

Created:
6 years, 10 months ago by JF
Modified:
6 years, 10 months ago
Reviewers:
binji, Sam Clegg, Andy
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji
Visibility:
Public.

Description

NaCl documentation: add links for x86-{32,64} and MIPS32. Also improve explanation for PNaCl. R= sbc@chromium.org, binji@chromium.org, awatson@chromium.org TEST= none BUG= none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253025

Patch Set 1 #

Patch Set 2 : Re-upload, first failed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M native_client_sdk/doc_generated/reference/sandbox_internals/index.html View 1 chunk +16 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/reference/sandbox_internals/index.rst View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
JF
6 years, 10 months ago (2014-02-23 22:43:55 UTC) #1
Sam Clegg
On 2014/02/23 22:43:55, JF wrote: Can you re-upload?.. codereview is having issues again.
6 years, 10 months ago (2014-02-24 21:20:20 UTC) #2
JF
On 2014/02/24 21:20:20, Sam Clegg wrote: > On 2014/02/23 22:43:55, JF wrote: > > Can ...
6 years, 10 months ago (2014-02-24 21:38:45 UTC) #3
Sam Clegg
lgtm
6 years, 10 months ago (2014-02-24 22:53:25 UTC) #4
JF
The CQ bit was checked by jfb@chromium.org
6 years, 10 months ago (2014-02-24 23:23:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/176663002/70001
6 years, 10 months ago (2014-02-24 23:26:33 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 23:31:26 UTC) #7
Message was sent while issue was closed.
Change committed as 253025

Powered by Google App Engine
This is Rietveld 408576698