Revert of Replace std::string::find with base::StartsWith when comparing cookie paths.

Revert of Replace std::string::find with base::StartsWith when comparing cookie paths. (patchset #5 id:100001 of https://codereview.chromium.org/1746303002/ )

Reason for revert:
This CL seems to have caused a cookie test to fail on the Mac valgrind bot. As it is a test failure, not memory error, being reported I think it is worth investigating.

See https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/37976.

Sample bot output:
CookieMonsterTest.PersisentCookieStorageTest:
../../net/cookies/cookie_monster_unittest.cc:2371: Failure
Value of: store->commands().size()
Actual: 6
Expected: 5u
Which is: 5

Original issue's description:
> Replace std::string::find with base::StartsWith when comparing cookie paths.
>
> The old code was correct, and the performance benefits are minimal, but
> "path1.find(path2) != 0" is a bit obscure.
>
> Also switch DeleteCookie to CanonicalCookie::IsOnPath to compare cookies,
> to match normal cookie semantics.
>
> BUG=583482
>
> Committed: https://crrev.com/23b6717eac3a002b02aa9951d62bec2b641fe947
> Cr-Commit-Position: refs/heads/master@{#379092}

TBR=mkwst@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583482
Committed: https://crrev.com/3e32f97dfa5c21eef32c1bdca055752284218959
Cr-Commit-Position: refs/heads/master@{#379216}

[benwells, 2016-03-04 05:00:03]

Created Revert of Replace std::string::find with base::StartsWith when comparing
cookie paths.

[commit-bot: I haz the power, 2016-03-04 05:00:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766613002/1

[commit-bot: I haz the power, 2016-03-04 05:00:53]

Description was changed from

==========
Revert of Replace std::string::find with base::StartsWith when comparing cookie
paths. (patchset #5 id:100001 of https://codereview.chromium.org/1746303002/ )

Reason for revert:
This CL seems to have caused a cookie test to fail on the Mac valgrind bot. As
it is a test failure, not memory error, being reported I think it is worth
investigating.

See
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%2....

Sample bot output:
CookieMonsterTest.PersisentCookieStorageTest:
../../net/cookies/cookie_monster_unittest.cc:2371: Failure
Value of: store->commands().size()
Actual: 6
Expected: 5u
Which is: 5

Original issue's description:
> Replace std::string::find with base::StartsWith when comparing cookie paths.
> 
> The old code was correct, and the performance benefits are minimal, but
> "path1.find(path2) != 0" is a bit obscure.
> 
> Also switch DeleteCookie to CanonicalCookie::IsOnPath to compare cookies,
> to match normal cookie semantics.
> 
> BUG=583482
> 
> Committed: https://crrev.com/23b6717eac3a002b02aa9951d62bec2b641fe947
> Cr-Commit-Position: refs/heads/master@{#379092}

TBR=mkwst@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583482
==========

to

==========
Revert of Replace std::string::find with base::StartsWith when comparing cookie
paths. (patchset #5 id:100001 of https://codereview.chromium.org/1746303002/ )

Reason for revert:
This CL seems to have caused a cookie test to fail on the Mac valgrind bot. As
it is a test failure, not memory error, being reported I think it is worth
investigating.

See
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%2....

Sample bot output:
CookieMonsterTest.PersisentCookieStorageTest:
../../net/cookies/cookie_monster_unittest.cc:2371: Failure
Value of: store->commands().size()
Actual: 6
Expected: 5u
Which is: 5

Original issue's description:
> Replace std::string::find with base::StartsWith when comparing cookie paths.
> 
> The old code was correct, and the performance benefits are minimal, but
> "path1.find(path2) != 0" is a bit obscure.
> 
> Also switch DeleteCookie to CanonicalCookie::IsOnPath to compare cookies,
> to match normal cookie semantics.
> 
> BUG=583482
> 
> Committed: https://crrev.com/23b6717eac3a002b02aa9951d62bec2b641fe947
> Cr-Commit-Position: refs/heads/master@{#379092}

TBR=mkwst@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583482
==========

[commit-bot: I haz the power, 2016-03-04 05:00:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-04 05:02:38]

Description was changed from

==========
Revert of Replace std::string::find with base::StartsWith when comparing cookie
paths. (patchset #5 id:100001 of https://codereview.chromium.org/1746303002/ )

Reason for revert:
This CL seems to have caused a cookie test to fail on the Mac valgrind bot. As
it is a test failure, not memory error, being reported I think it is worth
investigating.

See
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%2....

Sample bot output:
CookieMonsterTest.PersisentCookieStorageTest:
../../net/cookies/cookie_monster_unittest.cc:2371: Failure
Value of: store->commands().size()
Actual: 6
Expected: 5u
Which is: 5

Original issue's description:
> Replace std::string::find with base::StartsWith when comparing cookie paths.
> 
> The old code was correct, and the performance benefits are minimal, but
> "path1.find(path2) != 0" is a bit obscure.
> 
> Also switch DeleteCookie to CanonicalCookie::IsOnPath to compare cookies,
> to match normal cookie semantics.
> 
> BUG=583482
> 
> Committed: https://crrev.com/23b6717eac3a002b02aa9951d62bec2b641fe947
> Cr-Commit-Position: refs/heads/master@{#379092}

TBR=mkwst@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583482
==========

to

==========
Revert of Replace std::string::find with base::StartsWith when comparing cookie
paths. (patchset #5 id:100001 of https://codereview.chromium.org/1746303002/ )

Reason for revert:
This CL seems to have caused a cookie test to fail on the Mac valgrind bot. As
it is a test failure, not memory error, being reported I think it is worth
investigating.

See
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%2....

Sample bot output:
CookieMonsterTest.PersisentCookieStorageTest:
../../net/cookies/cookie_monster_unittest.cc:2371: Failure
Value of: store->commands().size()
Actual: 6
Expected: 5u
Which is: 5

Original issue's description:
> Replace std::string::find with base::StartsWith when comparing cookie paths.
>
> The old code was correct, and the performance benefits are minimal, but
> "path1.find(path2) != 0" is a bit obscure.
>
> Also switch DeleteCookie to CanonicalCookie::IsOnPath to compare cookies,
> to match normal cookie semantics.
>
> BUG=583482
>
> Committed: https://crrev.com/23b6717eac3a002b02aa9951d62bec2b641fe947
> Cr-Commit-Position: refs/heads/master@{#379092}

TBR=mkwst@chromium.org,mmenke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583482

Committed: https://crrev.com/3e32f97dfa5c21eef32c1bdca055752284218959
Cr-Commit-Position: refs/heads/master@{#379216}
==========

[commit-bot: I haz the power, 2016-03-04 05:02:39]

Patchset 1 (id:??) landed as
https://crrev.com/3e32f97dfa5c21eef32c1bdca055752284218959
Cr-Commit-Position: refs/heads/master@{#379216}