Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: Makefile.standalone

Issue 1766603002: Subzero: Fix "make presubmit" for spec -Om1. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index cd1d414b22c6e7daa45e8412355aecde1a01dfe6..7f80e2fddcb1f75aeb2ff43d111374ddeafcd650 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -502,19 +502,19 @@ TARGET := x8632
ifeq ($(TARGET),x8632)
TARGETFLAG=x8632
SETUP=SetupGccX8632Opt
- SPEC := -O2 --filetype=obj
+ SPEC := --filetype=obj
endif
ifeq ($(TARGET),x8664)
TARGETFLAG=x8664
SETUP=SetupGccX8664Opt
- SPEC := -O2 --filetype=obj
+ SPEC := --filetype=obj
endif
ifeq ($(TARGET),arm32)
TARGETFLAG=arm32
SETUP=SetupGccArmOpt
- SPEC := -O2 --filetype=obj
+ SPEC := --filetype=obj
endif
-SPECFLAGS :=
+SPECFLAGS := -O2
SPECBUILDONLY := false
%.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime
./pydir/szbuild_spec2k.py -v \
@@ -552,10 +552,10 @@ check-presubmit presubmit:
SPECFLAGS='-Om1' TARGET=x8664 SPECBUILDONLY=true check-spec
# Run spec2k for x86-32 without advanced phi lowering.
+make -f Makefile.standalone \
- SPECFLAGS='--sz=--phi-edge-split=0' check-spec
+ SPECFLAGS='-O2 --sz=--phi-edge-split=0' check-spec
# Run spec2k for x86-64 without advanced phi lowering.
+make -f Makefile.standalone \
- SPECFLAGS='--sz=--phi-edge-split=0' TARGET=x8664 check-spec
+ SPECFLAGS='-O2 --sz=--phi-edge-split=0' TARGET=x8664 check-spec
# Run cross tests and lit tests to validate filetype=asm output.
+make -f Makefile.standalone \
FORCEASM=1 check-xtest check-lit
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698