Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1766603002: Subzero: Fix "make presubmit" for spec -Om1. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix "make presubmit" for spec -Om1. For the Om1 spec tests, we were generating commands like this: ./pydir/szbuild_spec2k.py -v -Om1 --target=x8632 -O2 --filetype=obj 253.perlbmk where -Om1 and -O2 both appear. Python's argparse allows an argument to be set multiple times, and the last one would win, i.e. -O2 is used instead of -Om1. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c8f56a39aaa83bbe797945bf6d9a4faf2d180299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Makefile.standalone View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-03-04 04:14:57 UTC) #3
John
lgtm
4 years, 9 months ago (2016-03-04 15:07:42 UTC) #4
Jim Stichnoth
4 years, 9 months ago (2016-03-07 17:54:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8f56a39aaa83bbe797945bf6d9a4faf2d180299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698