Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4399)

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 1766493002: Restore the permission selection listing in the Origin Info Bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use ExclusiveAccessManager::IsSimplifiedFullscreenUIEnabled(). Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index 755a01d090287e12b9935363a335fb0fe0374415..9996abb1bd02d3c7a724eed37bce73aed2921872 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -698,13 +698,14 @@ void WebsiteSettings::PresentSitePermissions() {
NULL);
}
- if ((permission_info.setting != CONTENT_SETTING_DEFAULT &&
- permission_info.setting != permission_info.default_setting) ||
- (permission_info.type == CONTENT_SETTINGS_TYPE_KEYGEN &&
- tab_specific_content_settings()->IsContentBlocked(
- permission_info.type))) {
- permission_info_list.push_back(permission_info);
+ if (permission_info.type == CONTENT_SETTINGS_TYPE_KEYGEN &&
+ (permission_info.setting == CONTENT_SETTING_DEFAULT ||
+ permission_info.setting == permission_info.default_setting) &&
+ !tab_specific_content_settings()->IsContentBlocked(
+ permission_info.type)) {
+ continue;
}
+ permission_info_list.push_back(permission_info);
}
for (const ChooserUIInfo& ui_info : kChooserUIInfo) {
« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698