Sync confirmation: UI tweaks from bettes@

Sync confirmation: UI tweaks from bettes@

* <paper-buttons>s
 * Increase left/right padding
 * Change between spacing
 * Make height exactly 32px
 * Make font bold

* Decrease header size by 4px (to 52px total without border)

R=anthonyvd@chromium.org
BUG=533004
Committed: https://crrev.com/a6d65a1626f6ae0f44720b716d1d5fe2a22f637f
Cr-Commit-Position: refs/heads/master@{#379355}

[Dan Beam, 2016-03-04 02:12:38]

screenshot: http://i.imgur.com/58JcyYJ.png

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
File chrome/browser/resources/sync_confirmation/sync_confirmation.css (left):

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
chrome/browser/resources/sync_confirmation/sync_confirmation.css:6: font-size:
100%;
instead of making the bigger font-size the default and selectively reducing in
size, this does the opposite and enlarges selectively

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
File chrome/browser/resources/sync_confirmation/sync_confirmation.css (right):

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
chrome/browser/resources/sync_confirmation/sync_confirmation.css:23: height:
351px;
i can update this and the corresponding kSyncConfirmationDialogHeight if you
want me to, but overall i don't like this system (German promises to be longer,
Chinese promises to be shorter, the current value looks to be a stale
English-only default :/)

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
chrome/browser/resources/sync_confirmation/sync_confirmation.css:34: font-size:
16px;
i originally wanted to make this and the below line-height scale, but I think
you mentioned this UI doesn't actually inherit different font sizes from the
profile, right?

[anthonyvd, 2016-03-04 15:04:47]

lgtm with a question. Thanks Dan!

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
File chrome/browser/resources/sync_confirmation/sync_confirmation.css (right):

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
chrome/browser/resources/sync_confirmation/sync_confirmation.css:23: height:
351px;
On 2016/03/04 02:12:38, Dan Beam wrote:
> i can update this and the corresponding kSyncConfirmationDialogHeight if you
> want me to, but overall i don't like this system (German promises to be
longer,
> Chinese promises to be shorter, the current value looks to be a stale
> English-only default :/)

Not a fan either but I wasn't able to find any way of going around this. Is
there a way to make the dialog adapt to it's content?

From what I understand our only hope is to make it large enough and have enough
padding that it never overflows, which is indeed a pretty poor solution.

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
chrome/browser/resources/sync_confirmation/sync_confirmation.css:34: font-size:
16px;
On 2016/03/04 02:12:38, Dan Beam wrote:
> i originally wanted to make this and the below line-height scale, but I think
> you mentioned this UI doesn't actually inherit different font sizes from the
> profile, right?

It used to and it actually came up during UI review that it shouldn't since it's
not content so this is perfect. This was part of the tweaks I mentioned I had to
make yesterday.

[Dan Beam, 2016-03-04 20:11:10]

i think we should land this and go about the resizing/height in a followup

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
File chrome/browser/resources/sync_confirmation/sync_confirmation.css (right):

https://codereview.chromium.org/1766473003/diff/1/chrome/browser/resources/sy...
chrome/browser/resources/sync_confirmation/sync_confirmation.css:23: height:
351px;
On 2016/03/04 15:04:47, anthonyvd wrote:
> On 2016/03/04 02:12:38, Dan Beam wrote:
> > i can update this and the corresponding kSyncConfirmationDialogHeight if you
> > want me to, but overall i don't like this system (German promises to be
> longer,
> > Chinese promises to be shorter, the current value looks to be a stale
> > English-only default :/)
> 
> Not a fan either but I wasn't able to find any way of going around this. Is
> there a way to make the dialog adapt to it's content?

we could measure the scrollHeight of the <body> and message it's preferred
height to the C++ (which would resize the <webview>).  it's possible to get into
loops like this, but unlikely if we only do it once.

additionally, we could just set an English default and do this:

body {
  height: <english_px>;
  overflow-x: hidden;
  overflow-y: auto;
}

> 
> From what I understand our only hope is to make it large enough and have
enough
> padding that it never overflows, which is indeed a pretty poor solution.

[Dan Beam, 2016-03-04 20:11:24]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-03-04 20:11:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766473003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766473003/1

[commit-bot: I haz the power, 2016-03-04 20:58:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-04 21:01:08]

Description was changed from

==========
Sync confirmation: UI tweaks from bettes@

* <paper-buttons>s
 * Increase left/right padding
 * Change between spacing
 * Make height exactly 32px
 * Make font bold

* Decrease header size by 4px (to 52px total without border)

R=anthonyvd@chromium.org
BUG=533004
==========

to

==========
Sync confirmation: UI tweaks from bettes@

* <paper-buttons>s
 * Increase left/right padding
 * Change between spacing
 * Make height exactly 32px
 * Make font bold

* Decrease header size by 4px (to 52px total without border)

R=anthonyvd@chromium.org
BUG=533004

Committed: https://crrev.com/a6d65a1626f6ae0f44720b716d1d5fe2a22f637f
Cr-Commit-Position: refs/heads/master@{#379355}
==========

[commit-bot: I haz the power, 2016-03-04 21:01:09]

Patchset 1 (id:??) landed as
https://crrev.com/a6d65a1626f6ae0f44720b716d1d5fe2a22f637f
Cr-Commit-Position: refs/heads/master@{#379355}