Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 1766413002: Use a smart pointer for SkColorSpace factories (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use a smart pointer for SkColorSpace factories This should fix master-skia in Android because we no longer need to include src/core for SkCodec.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766413002 Committed: https://skia.googlesource.com/skia/+/ad8bcfeac4a684a64db3a7447aeea5bc35155f16

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M gyp/codec_android.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/codec/SkCodec.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/codec/SkBmpCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkCodec.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/codec/SkGifCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkJpegCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkPngCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkPngCodec.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M src/codec/SkRawCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkWbmpCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkWebpCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorSpace.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkColorSpace.cpp View 5 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarett
https://codereview.chromium.org/1766413002/diff/1/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/1766413002/diff/1/src/core/SkColorSpace.cpp#newcode123 src/core/SkColorSpace.cpp:123: return sk_sp<SkColorSpace>(new SkColorSpace(toXYZD50, gamma, kUnknown_Named)); Can't use sk_make_sp since ...
4 years, 9 months ago (2016-03-07 14:50:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766413002/20001
4 years, 9 months ago (2016-03-07 14:56:41 UTC) #5
reed1
lgtm
4 years, 9 months ago (2016-03-07 14:58:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 15:06:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766413002/20001
4 years, 9 months ago (2016-03-07 15:07:47 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 15:09:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ad8bcfeac4a684a64db3a7447aeea5bc35155f16

Powered by Google App Engine
This is Rietveld 408576698