Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and update them on undo/…

ui/file_manager/gallery/js/image_editor/image_editor.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * ImageEditor is the top level object that holds together and connects
  * everything needed for image editing.
  *
  * @param {!Viewport} viewport The viewport.
  * @param {!ImageView} imageView The ImageView containing the images to edit.
@@ skipping 305 matching lines @@
 };
 
 /**
  * Update Undo/Redo buttons state.
  */
 ImageEditor.prototype.updateUndoRedo = function() {
   var canUndo = this.commandQueue_ && this.commandQueue_.canUndo();
   var canRedo = this.commandQueue_ && this.commandQueue_.canRedo();
   ImageUtil.setAttribute(this.undoButton_, 'disabled', !canUndo);
   ImageUtil.setAttribute(this.redoButton_, 'disabled', !canRedo);
+  this.calculateModeApplicativity_();
 };
 
 /**
  * @return {HTMLCanvasElement|HTMLImageElement} The current image.
  */
 ImageEditor.prototype.getImage = function() {
   return this.getImageView().getImage();
 };
 
 /**
@@ skipping 292 matching lines @@
   if (!this.currentMode_.instant) {
     this.getViewport().setScreenTop(
         ImageEditor.Toolbar.HEIGHT + mode.paddingTop);
     this.getViewport().setScreenBottom(
         ImageEditor.Toolbar.HEIGHT * 2 + mode.paddingBottom);
     this.getImageView().applyViewportChange();
   }
 
   this.currentMode_.setUp();
 
+  this.calculateModeApplicativity_();

[yawano, 2016/03/07 11:16:18]

setUpMode_ is called when user has clicked each mode (e.g. AutoFix, Crop). We
need to disable each mode if the image is not applicable to it. i.e. We need to
call calculateModeApplicativity_ when user has entered to edit mode.

[ryoh, 2016/03/07 11:55:09]

That's right!
I introduce new callback, ImageEditor.prototype.onStartEditing, and call that
when user start editing image.

   if (this.currentMode_.instant) {  // Instant tool.
     this.leaveModeInternal_(true, false /* not to switch mode */);
     return;
   }
 
   this.exitButton_.hidden = true;
 
   this.modeToolbar_.clear();
   this.currentMode_.createTools(this.modeToolbar_);
   this.modeToolbar_.show(true);
-  this.calculateModeApplicativity_();
 };
 
 /**
  * Handles click event of Done button.
  * @param {!Event} event An event.
  * @private
  */
 ImageEditor.prototype.onDoneClicked_ = function(event) {
   this.leaveModeInternal_(true /* commit */, false /* not to switch mode */);
 };
@@ skipping 860 matching lines @@
 
 /**
  * Hide the prompt.
  */
 ImageEditor.Prompt.prototype.hide = function() {
   if (!this.prompt_) return;
   this.prompt_.setAttribute('state', 'fadeout');
   // Allow some time for the animation to play out.
   this.setTimer(this.reset.bind(this), 500);
 };