Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and update them on undo/…

Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and update them on undo/redo

BUG=591609
TEST=manually

Committed: https://crrev.com/5e534ef0d453c7aa40a2d4f973521bedd57d4c02
Cr-Commit-Position: refs/heads/master@{#379703}

[ryoh, 2016-03-07 10:41:50]

ryoh@chromium.org changed reviewers:
+ yawano@chromium.org

[ryoh, 2016-03-07 10:41:51]

Hi, could you take a look?
This bug occurs also on undo/redo.

[yawano, 2016-03-07 11:16:18]

https://codereview.chromium.org/1766343002/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/image_editor/image_editor.js (right):

https://codereview.chromium.org/1766343002/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/image_editor/image_editor.js:639:
this.calculateModeApplicativity_();
setUpMode_ is called when user has clicked each mode (e.g. AutoFix, Crop). We
need to disable each mode if the image is not applicable to it. i.e. We need to
call calculateModeApplicativity_ when user has entered to edit mode.

[ryoh, 2016-03-07 11:55:09]

Could you take another look?

https://codereview.chromium.org/1766343002/diff/1/ui/file_manager/gallery/js/...
File ui/file_manager/gallery/js/image_editor/image_editor.js (right):

https://codereview.chromium.org/1766343002/diff/1/ui/file_manager/gallery/js/...
ui/file_manager/gallery/js/image_editor/image_editor.js:639:
this.calculateModeApplicativity_();
On 2016/03/07 11:16:18, yawano wrote:
> setUpMode_ is called when user has clicked each mode (e.g. AutoFix, Crop). We
> need to disable each mode if the image is not applicable to it. i.e. We need
to
> call calculateModeApplicativity_ when user has entered to edit mode.

That's right!
I introduce new callback, ImageEditor.prototype.onStartEditing, and call that
when user start editing image.

[yawano, 2016-03-08 01:39:18]

lgtm. Thank you!

[ryoh, 2016-03-08 01:40:51]

The CQ bit was checked by ryoh@chromium.org

[ryoh, 2016-03-08 01:41:01]

On 2016/03/08 01:39:18, yawano wrote:
> lgtm. Thank you!

Thanks!

[commit-bot: I haz the power, 2016-03-08 01:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766343002/40001

[commit-bot: I haz the power, 2016-03-08 02:26:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-08 02:27:43]

Description was changed from

==========
Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and
update them on undo/redo

BUG=591609
TEST=manually
==========

to

==========
Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and
update them on undo/redo

BUG=591609
TEST=manually

Committed: https://crrev.com/5e534ef0d453c7aa40a2d4f973521bedd57d4c02
Cr-Commit-Position: refs/heads/master@{#379703}
==========

[commit-bot: I haz the power, 2016-03-08 02:27:44]

Patchset 3 (id:??) landed as
https://crrev.com/5e534ef0d453c7aa40a2d4f973521bedd57d4c02
Cr-Commit-Position: refs/heads/master@{#379703}