Issue 176633003: Disable another composited query assertion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176633003: Disable another composited query assertion. (Closed)

Created:
6 years, 10 months ago by dcheng

Modified:
6 years, 10 months ago

Reviewers:
abarth-chromium, ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Disable another composited query assertion. Hopefully this is the last of them... TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167648

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/core/rendering/RenderLayerScrollableArea.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dcheng

Committed patchset #1 manually as r167648 (tree was closed).

6 years, 10 months ago (2014-02-23 18:57:29 UTC) #1

ojan

Which test needed this? We need to add that in a comment so that the ...

6 years, 10 months ago (2014-02-24 18:06:26 UTC) #3

dcheng

6 years, 10 months ago (2014-02-24 18:28:13 UTC) #4

Message was sent while issue was closed.

On 2014/02/24 18:06:26, ojan wrote:
> Which test needed this? We need to add that in a comment so that the person
who
> goes in to fix this issue knows what test to run.

Building with GYP_DEFINES="chromeos=1 use_aura=1":
browser_tests
--gtest_filter=KioskHiddenWebUITest.AutolaunchWarning:OptionsWebUIExtendedTest.OverlayTabNavigation:PrintPreviewWebUITest.PrintScalingDisabledForPlugin:PrintPreviewWebUITest.PrintToPDFSelectedHideFitToPageOption:PrintPreviewWebUITest.SourceIsPDFShowFitToPageOption:RestorePrefs/FileManagerBrowserTest.Test/2:RestorePrefs/FileManagerBrowserTest.Test/3:TermsOfServiceTestInstance/TermsOfServiceTest.TermsOfServiceScreen/0

I didn't want to add references to Chrome tests in Blink, but if there's
precedence for that....
The other suppression I added (https://codereview.chromium.org/176633003/) was
triggered only the PrintPreviewWebUITests listed above.

Expand Messages | Collapse Messages