Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1766293002: [runtime] JSObject::GetKeys never returns the EnumCache, so we don't need to copy in GetPropertyNam… (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] JSObject::GetKeys never returns the EnumCache, so we don't need to copy in GetPropertyNames BUG=148757 LOG=n Committed: https://crrev.com/25064ff988dcaff628539d9d502cb797c3498a1b Cr-Commit-Position: refs/heads/master@{#34536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/api.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-07 08:44:56 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-07 10:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766293002/1
4 years, 9 months ago (2016-03-07 12:08:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 12:41:19 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 12:42:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25064ff988dcaff628539d9d502cb797c3498a1b
Cr-Commit-Position: refs/heads/master@{#34536}

Powered by Google App Engine
This is Rietveld 408576698