chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc - Issue 1766273002: Convert --enable-md-history to a feature flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 1766273002: Convert --enable-md-history to a feature flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated the name of kMaterialDesignHistoryFeature to Fix a unit-test failure. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

index bb85a656a97af5df400504e182f7dde30dca4a6e..ba66f8f815ea2a0910c67b03c757171883358be8 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -53,6 +53,7 @@

#include "chrome/browser/ui/webui/translate_internals/translate_internals_ui.h"

#include "chrome/browser/ui/webui/user_actions/user_actions_ui.h"

#include "chrome/browser/ui/webui/version_ui.h"

+#include "chrome/common/chrome_features.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

@@ -405,7 +406,7 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,

return &NewWebUI<extensions::ExtensionsUI>;

}

// Material Design history is on its own host, rather than on an Uber page.

- if (::switches::MdHistoryEnabled() &&

+ if (base::FeatureList::IsEnabled(features::kMaterialDesignHistoryFeature) &&

url.host() == chrome::kChromeUIHistoryHost) {

return &NewWebUI<MdHistoryUI>;

}