Convert --enable-md-history to a feature flag.

Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340
Committed: https://crrev.com/61ec142f0ff743e3f98a1e4ad7ea9d3baa42d75b
Cr-Commit-Position: refs/heads/master@{#381662}

[ddoman, 2016-03-07 23:18:59]

ddoman@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-03-10 02:44:30]

First review pass

https://codereview.chromium.org/1766273002/diff/40001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/1766273002/diff/40001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:695: // Enables or disables the Material Design
version of chrome:://history.
Nit: Single colon in chrome://history

https://codereview.chromium.org/1766273002/diff/40001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:697: "UsesMaterialDesignHistory",
base::FEATURE_DISABLED_BY_DEFAULT
There's no need for the "Uses" in this name, just

--enable-features MaterialDesignHistory

https://codereview.chromium.org/1766273002/diff/40001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1766273002/diff/40001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:193: extern const base::Feature
kMaterialDesignHistoryFeature;
Can you move this to chrome/common/chrome_features.{h/cc}?

[ddoman, 2016-03-10 04:46:05]

Hey Tim,

I made additional patches to fix unit-test failures and to isolate the impact of
a feature override for kMaterialDesignHistoryFeatures within
UberUIBrowserTest.EnableMdHistoryHidesHistory().

Please take a look at the patches and let me know for any suggestions.

Thanks,
Scott

[ddoman, 2016-03-10 04:47:18]

On 2016/03/10 04:46:05, ddoman wrote:
> Hey Tim,
> 
> I made additional patches to fix unit-test failures and to isolate the impact
of
> a feature override for kMaterialDesignHistoryFeatures within
> UberUIBrowserTest.EnableMdHistoryHidesHistory().
> 
> Please take a look at the patches and let me know for any suggestions.
> 
> Thanks,
> Scott

I could verify that the singleton instance of base::FeatureList gets recreated
for each of gtest.

[tsergeant, 2016-03-10 05:23:35]

I mailed out some more comments earlier this afternoon

https://codereview.chromium.org/1766273002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/uber/uber_ui_browsertest.cc (right):

https://codereview.chromium.org/1766273002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/uber/uber_ui_browsertest.cc:96:
scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
This bit looks good to me.

[tsergeant, 2016-03-11 04:48:38]

lgtm with one nit

https://codereview.chromium.org/1766273002/diff/120001/chrome/common/chrome_s...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1766273002/diff/120001/chrome/common/chrome_s...
chrome/common/chrome_switches.h:11: #include "base/feature_list.h"
Nit: Remove this line

[ddoman, 2016-03-11 06:02:59]

ddoman@chromium.org changed reviewers:
+ thestig@chromium.org

[ddoman, 2016-03-11 06:03:00]

Hi Lei,

I am wondering if you can take a look at this CL and review the changes.

Thanks,
Scott

https://codereview.chromium.org/1766273002/diff/120001/chrome/common/chrome_s...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/1766273002/diff/120001/chrome/common/chrome_s...
chrome/common/chrome_switches.h:11: #include "base/feature_list.h"
On 2016/03/11 04:48:38, tsergeant wrote:
> Nit: Remove this line

Done.

[ddoman, 2016-03-14 05:19:47]

The CQ bit was checked by ddoman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 05:19:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766273002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766273002/140001

[commit-bot: I haz the power, 2016-03-14 05:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 05:21:28]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ddoman1, 2016-03-14 06:48:27]

The CQ bit was checked by ddoman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 06:48:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766273002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766273002/160001

[commit-bot: I haz the power, 2016-03-14 08:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 08:33:04]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-03-16 23:11:46]

thestig@chromium.org changed reviewers:
+ dbeam@chromium.org

[Lei Zhang, 2016-03-16 23:11:47]

+dbeam since I'm Out Of Office.

BTW, why has https://crbug.com/585340 which this CL references, been deleted?

[ddoman, 2016-03-17 00:23:33]

Description was changed from

==========
Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=585340
==========

to

==========
Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340
==========

[ddoman, 2016-03-17 00:25:46]

On 2016/03/16 23:11:47, Lei Zhang (OOO) wrote:
> +dbeam since I'm Out Of Office.
> 
> BTW, why has https://crbug.com/585340 which this CL references, been deleted?

It was a typo. Updated with a correct bug #.

Thanks tsergeant@ for that.

[Dan Beam, 2016-03-17 01:40:54]

lgtm

[ddoman, 2016-03-17 01:48:42]

The CQ bit was checked by ddoman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 01:49:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766273002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766273002/160001

[commit-bot: I haz the power, 2016-03-17 03:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 03:07:22]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-03-17 04:37:59]

On 2016/03/17 01:40:54, Dan Beam wrote:
> lgtm

rs lgtm

[ddoman, 2016-03-17 04:59:13]

The CQ bit was checked by ddoman@chromium.org

[ddoman, 2016-03-17 04:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/1766273002/#ps160001
(title: "Sync to the latest update and resolve a merge conflict")

[commit-bot: I haz the power, 2016-03-17 04:59:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766273002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766273002/160001

[commit-bot: I haz the power, 2016-03-17 05:03:50]

Description was changed from

==========
Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340
==========

to

==========
Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340
==========

[commit-bot: I haz the power, 2016-03-17 05:03:52]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-17 05:05:20]

Description was changed from

==========
Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340
==========

to

==========
Convert --enable-md-history to a feature flag.

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340

Committed: https://crrev.com/61ec142f0ff743e3f98a1e4ad7ea9d3baa42d75b
Cr-Commit-Position: refs/heads/master@{#381662}
==========

[commit-bot: I haz the power, 2016-03-17 05:05:21]

Patchset 9 (id:??) landed as
https://crrev.com/61ec142f0ff743e3f98a1e4ad7ea9d3baa42d75b
Cr-Commit-Position: refs/heads/master@{#381662}