Subzero: Fix symbol name mangling. Make flags global.

src/PNaClTranslator.cpp

Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 1fb84c16b76e32f44592ed8670210b7e12031439..595b2340eb515b1ed3878e3596ebecc26e2bded0 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -508,16 +508,15 @@ private:
     }
   }
 
-  // Builds a constant symbol named Name, suppressing name mangling if
-  // SuppressMangling. IsExternal is true iff the symbol is external.
+  // Builds a constant symbol named Name.  IsExternal is true iff the symbol is
+  // external.
   Ice::Constant *getConstantSym(const Ice::IceString &Name,
-                                bool SuppressMangling, bool IsExternal) const {
+                                bool IsExternal) const {
     if (IsExternal) {
       return getTranslator().getContext()->getConstantExternSym(Name);
     } else {
       const Ice::RelocOffsetT Offset = 0;
-      return getTranslator().getContext()->getConstantSym(Offset, Name,
-                                                          SuppressMangling);
+      return getTranslator().getContext()->getConstantSym(Offset, Name);
     }
   }
 
@@ -538,8 +537,7 @@ private:
     for (const Ice::FunctionDeclaration *Func : FunctionDeclarations) {
       if (!Func->verifyLinkageCorrect(Ctx))
         reportLinkageError("Function", *Func);
-      Ice::Constant *C = getConstantSym(
-          Func->getName(), Func->getSuppressMangling(), Func->isProto());
+      Ice::Constant *C = getConstantSym(Func->getName(), Func->isProto());
       ValueIDConstants.push_back(C);
     }
   }
@@ -551,8 +549,7 @@ private:
       if (!Decl->verifyLinkageCorrect(Ctx))
         reportLinkageError("Global", *Decl);
       Ice::Constant *C =
-          getConstantSym(Decl->getName(), Decl->getSuppressMangling(),
-                         !Decl->hasInitializer());
+          getConstantSym(Decl->getName(), !Decl->hasInitializer());
       ValueIDConstants.push_back(C);
     }
   }