src/IceTargetLoweringX8632.cpp - Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index be26073c023b1bd8f69aa9679a51e760ae6bc3ce..ebf55f56d52d048eeadbae339ace4bea09dd6ff3 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -254,7 +254,7 @@ void TargetX8632::emitGetIP(CfgNode *Node) {

auto *GotFromPc = llvm::cast<ConstantRelocatable>(

Ctx->getConstantSym(ImmSize, {AfterAddReloc, BeforeAddReloc},

- GlobalOffsetTable, GlobalOffsetTable, true));

+ GlobalOffsetTable, GlobalOffsetTable));

// Insert a new version of InstX86GetIP.

Context.insert<Traits::Insts::GetIP>(CallDest);

« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringX8664.cpp » ('j') | no next file with comments »