src/IceIntrinsics.cpp - Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceIntrinsics.cpp

Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceIntrinsics.cpp

diff --git a/src/IceIntrinsics.cpp b/src/IceIntrinsics.cpp

index 94e582fa083a96c0aa3480678b4de7e81905d4f2..748aeb1e37a1c79e607c4f28b1221b4776473a3a 100644

--- a/src/IceIntrinsics.cpp

+++ b/src/IceIntrinsics.cpp

@@ -236,7 +236,7 @@ const Intrinsics::FullIntrinsicInfo *Intrinsics::find(const IceString &Name,

Error = false;

if (Name.substr(0, LLVMPrefixLen) != LLVMPrefix)

return nullptr;

- IceString NameSuffix = Name.substr(LLVMPrefixLen);

+ const IceString NameSuffix = Name.substr(LLVMPrefixLen);

auto it = Map.find(NameSuffix);

if (it == Map.end()) {

Error = true;

« no previous file with comments | « src/IceInstMIPS32.cpp ('k') | src/IceMangling.h » ('j') | no next file with comments »