src/IceInstMIPS32.cpp - Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstMIPS32.cpp

Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstMIPS32.cpp

diff --git a/src/IceInstMIPS32.cpp b/src/IceInstMIPS32.cpp

index 0cdf8a2265159dd15fb8c217446fccab2966b8f4..dcd977df56d31b3d958d530b8a2da803f6c4374a 100644

--- a/src/IceInstMIPS32.cpp

+++ b/src/IceInstMIPS32.cpp

@@ -118,7 +118,7 @@ InstMIPS32Label::InstMIPS32Label(Cfg *Func, TargetMIPS32 *Target)

IceString InstMIPS32Label::getName(const Cfg *Func) const {

if (!BuildDefs::dump())

- return IceString();

+ return "";

return ".L" + Func->getFunctionName() + "$local$__" + std::to_string(Number);

}

« no previous file with comments | « src/IceInstARM32.cpp ('k') | src/IceIntrinsics.cpp » ('j') | no next file with comments »