src/IceCfgNode.cpp - Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfgNode.cpp

Issue 1766233002: Subzero: Fix symbol name mangling. Make flags global. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfgNode.cpp

diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp

index 6cadcf65ec63f87139fc9c373caa748aa84b697a..0729585bf14f8bcad1fe5b84c8ac04f138f6c700 100644

--- a/src/IceCfgNode.cpp

+++ b/src/IceCfgNode.cpp

@@ -1431,9 +1431,7 @@ void CfgNode::profileExecutionCount(VariableDeclaration *Var) {

Operand *RMWI64Name = Context->getConstantExternSym(RMW_I64);

constexpr RelocOffsetT Offset = 0;

- constexpr bool SuppressMangling = true;

- Constant *Counter =

- Context->getConstantSym(Offset, Var->getName(), SuppressMangling);

+ Constant *Counter = Context->getConstantSym(Offset, Var->getName());

Constant *AtomicRMWOp = Context->getConstantInt32(Intrinsics::AtomicAdd);

Constant *One = Context->getConstantInt64(1);

Constant *OrderAcquireRelease =

« no previous file with comments | « src/IceCfg.cpp ('k') | src/IceClFlags.h » ('j') | no next file with comments »