Subzero: Fix symbol name mangling. Make flags global.

src/PNaClTranslator.cpp

 //===- subzero/src/PNaClTranslator.cpp - ICE from bitcode -----------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 490 matching lines @@
     const Ice::IceString &FunctionPrefix =
         getTranslator().getFlags().getDefaultFunctionPrefix();
     if (!FunctionPrefix.empty()) {
       NaClBcIndexSize_t NameIndex = 0;
       for (Ice::FunctionDeclaration *Func : FunctionDeclarations) {
         installDeclarationName(Func, FunctionPrefix, "function", NameIndex);
       }
     }
   }
 
-  // Builds a constant symbol named Name, suppressing name mangling if
-  // SuppressMangling. IsExternal is true iff the symbol is external.
+  // Builds a constant symbol named Name.  IsExternal is true iff the symbol is
+  // external.
   Ice::Constant *getConstantSym(const Ice::IceString &Name,
-                                bool SuppressMangling, bool IsExternal) const {
+                                bool IsExternal) const {
     if (IsExternal) {
       return getTranslator().getContext()->getConstantExternSym(Name);
     } else {
       const Ice::RelocOffsetT Offset = 0;
-      return getTranslator().getContext()->getConstantSym(Offset, Name,
-                                                          SuppressMangling);
+      return getTranslator().getContext()->getConstantSym(Offset, Name);
     }
   }
 
   void reportLinkageError(const char *Kind,
                           const Ice::GlobalDeclaration &Decl) {
     std::string Buffer;
     raw_string_ostream StrBuf(Buffer);
     StrBuf << Kind << " " << Decl.getName()
            << " has incorrect linkage: " << Decl.getLinkageName();
     if (Decl.isExternal())
       StrBuf << "\n  Use flag -allow-externally-defined-symbols to override";
     Error(StrBuf.str());
   }
 
   // Converts function declarations into constant value IDs.
   void createValueIDsForFunctions() {
     Ice::GlobalContext *Ctx = getTranslator().getContext();
     for (const Ice::FunctionDeclaration *Func : FunctionDeclarations) {
       if (!Func->verifyLinkageCorrect(Ctx))
         reportLinkageError("Function", *Func);
-      Ice::Constant *C = getConstantSym(
-          Func->getName(), Func->getSuppressMangling(), Func->isProto());
+      Ice::Constant *C = getConstantSym(Func->getName(), Func->isProto());
       ValueIDConstants.push_back(C);
     }
   }
 
   // Converts global variable declarations into constant value IDs.
   void createValueIDsForGlobalVars() {
     Ice::GlobalContext *Ctx = getTranslator().getContext();
     for (const Ice::VariableDeclaration *Decl : *VariableDeclarations) {
       if (!Decl->verifyLinkageCorrect(Ctx))
         reportLinkageError("Global", *Decl);
       Ice::Constant *C =
-          getConstantSym(Decl->getName(), Decl->getSuppressMangling(),
-                         !Decl->hasInitializer());
+          getConstantSym(Decl->getName(), !Decl->hasInitializer());
       ValueIDConstants.push_back(C);
     }
   }
 
   // Reports that type ID is undefined, or not of the WantedType.
   void reportBadTypeIDAs(NaClBcIndexSize_t ID, const ExtendedType *Ty,
                          ExtendedType::TypeKind WantedType);
 
   // Reports that there is no function declaration for ID. Returns an error
   // recovery value to use.
@@ skipping 2639 matching lines @@
     raw_string_ostream StrBuf(Buffer);
     StrBuf << IRFilename << ": Does not contain a module!";
     llvm::report_fatal_error(StrBuf.str());
   }
   if (InputStreamFile.getBitcodeBytes().getExtent() % 4 != 0) {
     llvm::report_fatal_error("Bitcode stream should be a multiple of 4 bytes");
   }
 }
 
 } // end of namespace Ice