Subzero: Fix symbol name mangling. Make flags global.

src/IceConverter.cpp

 //===- subzero/src/IceConverter.cpp - Converts LLVM to Ice  ---------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
 /// \brief Implements the LLVM to ICE converter.
 ///
 //===----------------------------------------------------------------------===//
 
 #include "IceConverter.h"
 
 #include "IceCfg.h"
 #include "IceCfgNode.h"
 #include "IceClFlags.h"
 #include "IceDefs.h"
 #include "IceGlobalContext.h"
 #include "IceGlobalInits.h"
 #include "IceInst.h"
+#include "IceMangling.h"
 #include "IceOperand.h"
 #include "IceTargetLowering.h"
 #include "IceTypes.h"
 #include "IceTypeConverter.h"
 
 #ifdef __clang__
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wunused-parameter"
 #endif // __clang__
 
@@ skipping 60 matching lines @@
   explicit LLVM2ICEFunctionConverter(Ice::Converter &Converter)
       : LLVM2ICEConverter(Converter), Func(nullptr) {}
 
   void convertFunction(const Function *F) {
     Func = Ice::Cfg::create(Ctx, Converter.getNextSequenceNumber());
     {
       Ice::CfgLocalAllocatorScope _(Func.get());
 
       VarMap.clear();
       NodeMap.clear();
-      Func->setFunctionName(F->getName());
+      Func->setFunctionName(Ice::mangleName(F->getName()));
       Func->setReturnType(convertToIceType(F->getReturnType()));
       Func->setInternal(F->hasInternalLinkage());
       Ice::TimerMarker T(Ice::TimerStack::TT_llvmConvert, Func.get());
 
       // The initial definition/use of each arg is the entry node.
       for (auto ArgI = F->arg_begin(), ArgE = F->arg_end(); ArgI != ArgE;
            ++ArgI) {
         Func->addArg(mapValueToIceVar(ArgI));
       }
 
@@ skipping 19 matching lines @@
       if (const auto *Func = llvm::dyn_cast<Ice::FunctionDeclaration>(Decl))
         IsUndefined = Func->isProto();
       else if (const auto *Var = llvm::dyn_cast<Ice::VariableDeclaration>(Decl))
         IsUndefined = !Var->hasInitializer();
       else
         report_fatal_error("Unhandled GlobalDeclaration type");
       if (IsUndefined)
         return Ctx->getConstantExternSym(Decl->getName());
       else {
         const Ice::RelocOffsetT Offset = 0;
-        return Ctx->getConstantSym(Offset, Decl->getName(),
-                                   Decl->getSuppressMangling());
+        return Ctx->getConstantSym(Offset, Decl->getName());
       }
     } else if (const auto CI = dyn_cast<ConstantInt>(Const)) {
       Ice::Type Ty = convertToIceType(CI->getType());
       return Ctx->getConstantInt(Ty, CI->getSExtValue());
     } else if (const auto CFP = dyn_cast<ConstantFP>(Const)) {
       Ice::Type Type = convertToIceType(CFP->getType());
       if (Type == Ice::IceType_f32)
         return Ctx->getConstantFloat(CFP->getValueAPF().convertToFloat());
       else if (Type == Ice::IceType_f64)
         return Ctx->getConstantDouble(CFP->getValueAPF().convertToDouble());
@@ skipping 726 matching lines @@
     }
     if (!IceFunc->validateTypeSignature(Ctx))
       report_fatal_error(IceFunc->getTypeSignatureError(Ctx));
     GlobalDeclarationMap[&Func] = IceFunc;
   }
   // Install global variable declarations.
   for (Module::const_global_iterator I = Mod->global_begin(),
                                      E = Mod->global_end();
        I != E; ++I) {
     const GlobalVariable *GV = I;
-    auto *Var = VariableDeclaration::create(Ctx);
-    Var->setName(GV->getName());
+    constexpr bool NoSuppressMangling = false;
+    auto *Var =
+        VariableDeclaration::create(Ctx, NoSuppressMangling, GV->getLinkage());
     Var->setAlignment(GV->getAlignment());
     Var->setIsConstant(GV->isConstant());
-    Var->setLinkage(GV->getLinkage());
+    Var->setName(GV->getName());
     if (!Var->verifyLinkageCorrect(Ctx)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Global " << Var->getName()
              << " has incorrect linkage: " << Var->getLinkageName();
       if (Var->isExternal())
         StrBuf << "\n  Use flag -allow-externally-defined-symbols to override";
       report_fatal_error(StrBuf.str());
     }
     GlobalDeclarationMap[GV] = Var;
@@ skipping 17 matching lines @@
       Ctx->pushTimer(TimerID, StackID);
     }
     LLVM2ICEFunctionConverter FunctionConverter(*this);
     FunctionConverter.convertFunction(&I);
     if (TimeThisFunction)
       Ctx->popTimer(TimerID, StackID);
   }
 }
 
 } // end of namespace Ice