Subzero: Fix symbol name mangling. Make flags global.

src/IceCfg.cpp

 //===- subzero/src/IceCfg.cpp - Control flow graph implementation ---------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 956 matching lines @@
   for (const InstJumpTable *JT : JumpTables)
     for (SizeT I = 0; I < JT->getNumTargets(); ++I)
       JT->getTarget(I)->setNeedsAlignment();
 }
 
 // ======================== Dump routines ======================== //
 
 // emitTextHeader() is not target-specific (apart from what is abstracted by
 // the Assembler), so it is defined here rather than in the target lowering
 // class.
-void Cfg::emitTextHeader(const IceString &MangledName, GlobalContext *Ctx,
+void Cfg::emitTextHeader(const IceString &Name, GlobalContext *Ctx,
                          const Assembler *Asm) {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Ctx->getStrEmit();
   Str << "\t.text\n";
   if (Ctx->getFlags().getFunctionSections())
-    Str << "\t.section\t.text." << MangledName << ",\"ax\",%progbits\n";
+    Str << "\t.section\t.text." << Name << ",\"ax\",%progbits\n";
   if (!Asm->getInternal() || Ctx->getFlags().getDisableInternal()) {
-    Str << "\t.globl\t" << MangledName << "\n";
-    Str << "\t.type\t" << MangledName << ",%function\n";
+    Str << "\t.globl\t" << Name << "\n";
+    Str << "\t.type\t" << Name << ",%function\n";
   }
   Str << "\t" << Asm->getAlignDirective() << " "
       << Asm->getBundleAlignLog2Bytes() << ",0x";
   for (uint8_t I : Asm->getNonExecBundlePadding())
     Str.write_hex(I);
   Str << "\n";
-  Str << MangledName << ":\n";
+  Str << Name << ":\n";
 }
 
 void Cfg::deleteJumpTableInsts() {
   for (InstJumpTable *JumpTable : JumpTables)
     JumpTable->setDeleted();
 }
 
 void Cfg::emitJumpTables() {
   switch (Ctx->getFlags().getOutFileType()) {
   case FT_Elf:
   case FT_Iasm: {
     // The emission needs to be delayed until the after the text section so
     // save the offsets in the global context.
-    IceString MangledName = Ctx->mangleName(getFunctionName());
     for (const InstJumpTable *JumpTable : JumpTables) {
       SizeT NumTargets = JumpTable->getNumTargets();
       JumpTableData::TargetList TargetList;
       for (SizeT I = 0; I < NumTargets; ++I) {
         SizeT Index = JumpTable->getTarget(I)->getIndex();
         TargetList.emplace_back(
             getAssembler()->getCfgNodeLabel(Index)->getPosition());
       }
-      Ctx->addJumpTable(MangledName, JumpTable->getId(), TargetList);
+      Ctx->addJumpTable(FunctionName, JumpTable->getId(), TargetList);
     }
   } break;
   case FT_Asm: {
     // Emit the assembly directly so we don't need to hang on to all the names
     for (const InstJumpTable *JumpTable : JumpTables)
       getTarget()->emitJumpTable(this, JumpTable);
   } break;
   }
 }
 
 void Cfg::emit() {
   if (!BuildDefs::dump())
     return;
   TimerMarker T(TimerStack::TT_emit, this);
   if (Ctx->getFlags().getDecorateAsm()) {
     renumberInstructions();
     getVMetadata()->init(VMK_Uses);
     liveness(Liveness_Basic);
     dump("After recomputing liveness for -decorate-asm");
   }
   OstreamLocker L(Ctx);
   Ostream &Str = Ctx->getStrEmit();
-  IceString MangledName = Ctx->mangleName(getFunctionName());
   const Assembler *Asm = getAssembler<>();
   const bool NeedSandboxing = Ctx->getFlags().getUseSandboxing();
 
-  emitTextHeader(MangledName, Ctx, Asm);
+  emitTextHeader(FunctionName, Ctx, Asm);
   deleteJumpTableInsts();
   if (Ctx->getFlags().getDecorateAsm()) {
     for (Variable *Var : getVariables()) {
       if (Var->getStackOffset() && !Var->isRematerializable()) {
         Str << "\t" << Var->getSymbolicStackOffset(this) << " = "
             << Var->getStackOffset() << "\n";
       }
     }
   }
   for (CfgNode *Node : Nodes) {
@@ skipping 41 matching lines @@
     Str << "================ " << Message << " ================\n";
   if (isVerbose(IceV_Mem)) {
     Str << "Memory size = " << getTotalMemoryMB() << " MB\n";
   }
   setCurrentNode(getEntryNode());
   // Print function name+args
   if (isVerbose(IceV_Instructions)) {
     Str << "define ";
     if (getInternal() && !Ctx->getFlags().getDisableInternal())
       Str << "internal ";
-    Str << ReturnType << " @" << Ctx->mangleName(getFunctionName()) << "(";
+    Str << ReturnType << " @" << getFunctionName() << "(";
     for (SizeT i = 0; i < Args.size(); ++i) {
       if (i > 0)
         Str << ", ";
       Str << Args[i]->getType() << " ";
       Args[i]->dump(this);
     }
     // Append an extra copy of the function name here, in order to print its
     // size stats but not mess up lit tests.
     Str << ") { # " << getFunctionNameAndSize() << "\n";
   }
@@ skipping 28 matching lines @@
     }
   }
   // Print each basic block
   for (CfgNode *Node : Nodes)
     Node->dump(this);
   if (isVerbose(IceV_Instructions))
     Str << "}\n";
 }
 
 } // end of namespace Ice