Subzero: Fix symbol name mangling. Make flags global.

src/IceCfg.h

 //===- subzero/src/IceCfg.h - Control flow graph ----------------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 57 matching lines @@
 
   /// \name Manage errors.
   /// @{
 
   /// Translation error flagging. If support for some construct is known to be
   /// missing, instead of an assertion failure, setError() should be called and
   /// the error should be propagated back up. This way, we can gracefully fail
   /// to translate and let a fallback translator handle the function.
   void setError(const IceString &Message);
   bool hasError() const { return HasError; }
-  IceString getError() const { return ErrorMessage; }
+  const IceString &getError() const { return ErrorMessage; }

[John, 2016/03/06 22:39:38]

I understand this change, but consider this carefully. String references might
bite you are careless - especially with auto

[Jim Stichnoth, 2016/03/07 00:03:10]

You're right, no sense doing risks to optimize getting an error message.  
Reverted.

   /// @}
 
   /// \name Manage nodes (a.k.a. basic blocks, CfgNodes).
   /// @{
   void setEntryNode(CfgNode *EntryNode) { Entry = EntryNode; }
   CfgNode *getEntryNode() const { return Entry; }
   /// Create a node and append it to the end of the linearized list. The loop
   /// nest depth of the new node may not be valid if it is created after
   /// computeLoopNestDepth.
   CfgNode *makeNode();
@@ skipping 129 matching lines @@
   void resetCurrentNode() { setCurrentNode(nullptr); }
   const CfgNode *getCurrentNode() const { return CurrentNode; }
   /// @}
 
   /// Get the total amount of memory held by the per-Cfg allocator.  This is
   /// mostly meant for use inside a debugger.
   static size_t getTotalMemoryMB();
 
   void emit();
   void emitIAS();
-  static void emitTextHeader(const IceString &MangledName, GlobalContext *Ctx,
+  static void emitTextHeader(const IceString &Name, GlobalContext *Ctx,
                              const Assembler *Asm);
   void dump(const IceString &Message = "");
 
   /// Allocate data of type T using the per-Cfg allocator.
   template <typename T> T *allocate() { return Allocator->Allocate<T>(); }
 
   /// Allocate an array of data of type T using the per-Cfg allocator.
   template <typename T> T *allocateArrayOf(size_t NumElems) {
     return Allocator->Allocate<T>(NumElems);
   }
@@ skipping 72 matching lines @@
 
 public:
   static void TlsInit() { CfgAllocatorTraits::init(); }
 };
 
 template <> Variable *Cfg::makeVariable<Variable>(Type Ty);
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICECFG_H