Issue 176623003: Oilpan: move DOMURL to oilpan's heap.

Issue 176623003: Oilpan: move DOMURL to oilpan's heap. (Closed)

Created:
6 years, 10 months ago by sof

Modified:
6 years, 10 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, arv+blink, Mads Ager (chromium), sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, haraken, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: move DOMURL to oilpan's heap. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167673

Patch Set 2 : order decls #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
M	Source/core/dom/DOMURL.h	View		3 chunks	+11 lines, -8 lines	0 comments	Download
M	Source/core/dom/DOMURL.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/URL.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/heap/ThreadState.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. (Having DOMURL be GCed will enable the object structure in https://codereview.chromium.org/143313002/ ...

6 years, 10 months ago (2014-02-23 21:21:43 UTC) #1

haraken

LGTM https://codereview.chromium.org/176623003/diff/1/Source/heap/ThreadState.h File Source/heap/ThreadState.h (right): https://codereview.chromium.org/176623003/diff/1/Source/heap/ThreadState.h#newcode554 Source/heap/ThreadState.h:554: USED_FROM_MULTIPLE_THREADS(DOMURL); Nit: alphabetical order please.

6 years, 10 months ago (2014-02-24 00:39:44 UTC) #2

sof

https://codereview.chromium.org/176623003/diff/1/Source/heap/ThreadState.h File Source/heap/ThreadState.h (right): https://codereview.chromium.org/176623003/diff/1/Source/heap/ThreadState.h#newcode554 Source/heap/ThreadState.h:554: USED_FROM_MULTIPLE_THREADS(DOMURL); On 2014/02/24 00:39:44, haraken wrote: > > Nit: ...

6 years, 10 months ago (2014-02-24 06:09:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/176623003/80001

6 years, 10 months ago (2014-02-24 06:09:44 UTC) #5

Message was sent while issue was closed.

Change committed as 167673

Expand Messages | Collapse Messages