Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1766223002: Clear floats even when they are not tracked by a previous sibling (Closed)

Created:
4 years, 9 months ago by rhogan
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear floats even when they are not tracked by a previous sibling BUG=591243 Committed: https://crrev.com/24bc38bac8c8f2ca1ee61b8872829fcdde521fa3 Cr-Commit-Position: refs/heads/master@{#380248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/block-with-negative-margin-clears-float.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/block-with-negative-margin-clears-float-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rhogan
4 years, 9 months ago (2016-03-07 13:40:50 UTC) #2
rhogan
4 years, 9 months ago (2016-03-09 20:21:30 UTC) #4
eae
LGTM
4 years, 9 months ago (2016-03-09 21:13:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766223002/1
4 years, 9 months ago (2016-03-09 21:13:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 22:52:06 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:53:33 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24bc38bac8c8f2ca1ee61b8872829fcdde521fa3
Cr-Commit-Position: refs/heads/master@{#380248}

Powered by Google App Engine
This is Rietveld 408576698