[MD settings] change layout of Custom Font settings

[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786
Committed: https://crrev.com/ea2bc47092bed8e1a48fda9d6aa70fedc98e6ab0
Cr-Commit-Position: refs/heads/master@{#380173}

[dschuyler, 2016-03-05 02:06:49]

Description was changed from

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786
==========

to

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

Screenshot at http://imgur.com/PCQyFBR

BUG=531786
==========

[dschuyler, 2016-03-05 02:06:49]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-03-05 02:27:29]

LGTM.

Nit: How about removing the screenshot link from the CL description? Asking
because the git history will probably outlive the time the link will be working.

https://codereview.chromium.org/1766173002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
(right):

https://codereview.chromium.org/1766173002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html:17:
on-immediate-value-change="immediateSizeIndexChanged_" snaps>
Nit(optional): An alternative to forwarding on-immediate-value-change to
immediateSizeIndexChanged_ is to add an observer directly for
immediateSiveIndex_, see example at
https://www.polymer-project.org/1.0/docs/devguide/properties.html#change-call....

[dschuyler, 2016-03-08 20:09:14]

https://codereview.chromium.org/1766173002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
(right):

https://codereview.chromium.org/1766173002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html:17:
on-immediate-value-change="immediateSizeIndexChanged_" snaps>
On 2016/03/05 02:27:29, dpapad wrote:
> Nit(optional): An alternative to forwarding on-immediate-value-change to
> immediateSizeIndexChanged_ is to add an observer directly for
> immediateSiveIndex_, see example at
>
https://www.polymer-project.org/1.0/docs/devguide/properties.html#change-call....

Done.

[dschuyler, 2016-03-08 22:03:04]

Description was changed from

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

Screenshot at http://imgur.com/PCQyFBR

BUG=531786
==========

to

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786
==========

[dschuyler, 2016-03-09 01:05:00]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-03-09 01:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1766173002/#ps20001
(title: "nit changes")

[commit-bot: I haz the power, 2016-03-09 01:05:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766173002/20001

[dschuyler, 2016-03-09 19:20:35]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-03-09 19:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1766173002/#ps40001
(title: "merge with master")

[commit-bot: I haz the power, 2016-03-09 19:21:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766173002/40001

[commit-bot: I haz the power, 2016-03-09 19:27:18]

Description was changed from

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786
==========

to

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786
==========

[commit-bot: I haz the power, 2016-03-09 19:27:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-09 19:29:03]

Description was changed from

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786
==========

to

==========
[MD settings] change layout of Custom Font settings

This CL moves the font size and minimum font size sliders
to the top of the page.  This does not match the current
mocks, but instead comes from a conversation with Alan.
i.e. this layout supersedes the mocks.

BUG=531786

Committed: https://crrev.com/ea2bc47092bed8e1a48fda9d6aa70fedc98e6ab0
Cr-Commit-Position: refs/heads/master@{#380173}
==========

[commit-bot: I haz the power, 2016-03-09 19:29:04]

Patchset 3 (id:??) landed as
https://crrev.com/ea2bc47092bed8e1a48fda9d6aa70fedc98e6ab0
Cr-Commit-Position: refs/heads/master@{#380173}