Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1766153002: Add a test of depot across an asm.js -> wasm module. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a test of depot across an asm.js -> wasm module. This previously tickled the failure fixed in this issue: https://crrev.com/6a806a558158cbab55ad9a1a456942a7c509c810 BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=asm-wasm-deopt R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/2e87c7f5ae99c726960635b36b564ce37304579c Cr-Commit-Position: refs/heads/master@{#35064}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/wasm/asm-wasm-deopt.js View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bradn
4 years, 9 months ago (2016-03-24 17:06:24 UTC) #4
titzer
lgtm
4 years, 9 months ago (2016-03-24 17:10:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766153002/60001
4 years, 9 months ago (2016-03-24 17:13:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-24 17:27:45 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 17:28:37 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2e87c7f5ae99c726960635b36b564ce37304579c
Cr-Commit-Position: refs/heads/master@{#35064}

Powered by Google App Engine
This is Rietveld 408576698