Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1766043002: Try again to suppress mac warnings (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M xfa.gyp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
TBR
4 years, 9 months ago (2016-03-04 21:23:07 UTC) #2
Tom Sepez
Committed patchset #2 (id:20001) manually as c91f42a7ec3fdc57c76a9b175914ecfbd24a9a03 (presubmit successful).
4 years, 9 months ago (2016-03-04 21:23:44 UTC) #5
Oliver Chang
4 years, 9 months ago (2016-03-04 21:24:47 UTC) #6
Message was sent while issue was closed.
lgtm

at this rate it seems like we would need to disable all warnings :)

Powered by Google App Engine
This is Rietveld 408576698