Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1766033002:
roll gyp ed163ce233:61259d585c (Closed)
Descriptionroll gyp ed163ce233:61259d585c
61259d5 ninja/win: Use qualified paths for precompiled headers.
1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj
d84fed2 Fix tests with Xcode 7.
0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks.
BUG=none
R=scottmg@chromium.org
TBR=scottmg
Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678
Cr-Commit-Position: refs/heads/master@{#379373}
Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b0848509ee61e79a
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : let's try again #Patch Set 4 : again #
Messages
Total messages: 28 (13 generated)
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg ==========
thakis@chromium.org changed reviewers: + scottmg@chromium.org
thakis@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766033002/20001
lgtm
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1759323004/ by ortuno@chromium.org. The reason for reverting is: win trunk bot started failing after this patch: [45/14742] CXX obj\third_party\angle\src\libGLESv2\libGLESv2.entry_points_gles_2_0.obj FAILED: ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs2013_files\4087e065abebdca6dbd0caca2910c6718d2ec67f\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\webkit\source\build\win\blink_heap_asm_stubs.precompile.obj.rsp /c ..\..\third_party\WebKit\Source\build\win\Precompile.cpp /Foobj\third_party\webkit\source\build\win\blink_heap_asm_stubs.precompile.obj /Fdobj\third_party\WebKit\Source\platform\blink_heap_asm_stubs.cc.pdb c:\b\build\slave\win_trunk\build\src\third_party\webkit\source\build\win\precompile.cpp : fatal error C1083: Cannot open include file: 'third_party/WebKit/Source/build/win/Precompile.h': No such file or directory FAILED: ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs2013_files\4087e065abebdca6dbd0caca2910c6718d2ec67f\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\build\harfbuzz-ng.precompile.obj.rsp /c ..\..\build\precompile.cc /Foobj\build\harfbuzz-ng.precompile.obj /Fdobj\third_party\harfbuzz-ng\harfbuzz-ng.cc.pdb c:\b\build\slave\win_trunk\build\src\build\precompile.cc : fatal error C1083: Cannot open include file: 'build/precompile.h': No such file or directory ninja: build stopped: subcommand failed. Builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w... Job: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w... Logs:https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/26144/steps/compile/logs/stdio.
Message was sent while issue was closed.
okie, trying this again with patch set 3
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} ==========
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/1766033002/#ps40001 (title: "let's try again")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766033002/40001
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://crrev.com/bcc0a572a0388ec650894017b0848509ee61e79a Cr-Commit-Position: refs/heads/master@{#379422} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bcc0a572a0388ec650894017b0848509ee61e79a Cr-Commit-Position: refs/heads/master@{#379422}
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://crrev.com/bcc0a572a0388ec650894017b0848509ee61e79a Cr-Commit-Position: refs/heads/master@{#379422} ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b084... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as bcc0a572a0388ec650894017b0848509ee61e79a (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1765073003/ by thakis@chromium.org. The reason for reverting is: Same failure again..
Message was sent while issue was closed.
Trying this once more with patch set 4. The two failing targets work with that locally. (Spoiler: It was a silly mistake.)
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b084... ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b084... Committed: https://crrev.com/e531fbdc85e115919764e2eb53093e8117a802f6 Cr-Commit-Position: refs/heads/master@{#379555} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e531fbdc85e115919764e2eb53093e8117a802f6 Cr-Commit-Position: refs/heads/master@{#379555}
Message was sent while issue was closed.
Description was changed from ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b084... Committed: https://crrev.com/e531fbdc85e115919764e2eb53093e8117a802f6 Cr-Commit-Position: refs/heads/master@{#379555} ========== to ========== roll gyp ed163ce233:61259d585c 61259d5 ninja/win: Use qualified paths for precompiled headers. 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj d84fed2 Fix tests with Xcode 7. 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. BUG=none R=scottmg@chromium.org TBR=scottmg Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 Cr-Commit-Position: refs/heads/master@{#379373} Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b084... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) to pending queue manually as 8fdf3cad68ccf23c7de9644038062053a497f334 (presubmit successful). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
