Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: components/signin/core/browser/signin_header_helper.cc

Issue 1765993002: Remove UnescapeRule::URL_SPECIAL_CHARS from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix, merge Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_header_helper.cc
diff --git a/components/signin/core/browser/signin_header_helper.cc b/components/signin/core/browser/signin_header_helper.cc
index 319b6f88d08d1aaf85776736f45f4f3b5e197c9d..578cb5806cf889ec323d359d175515b17120ffdd 100644
--- a/components/signin/core/browser/signin_header_helper.cc
+++ b/components/signin/core/browser/signin_header_helper.cc
@@ -78,9 +78,10 @@ MirrorResponseHeaderDictionary ParseMirrorResponseHeader(
DLOG(WARNING) << "Unexpected GAIA header field '" << field << "'.";
continue;
}
- dictionary[field.substr(0, delim).as_string()] =
- net::UnescapeURLComponent(field.substr(delim + 1).as_string(),
- net::UnescapeRule::URL_SPECIAL_CHARS);
+ dictionary[field.substr(0, delim).as_string()] = net::UnescapeURLComponent(
+ field.substr(delim + 1).as_string(),
+ net::UnescapeRule::PATH_SEPARATORS |
mmenke 2016/03/16 21:30:01 I don't think we're getting anything that we use a
+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS);
}
return dictionary;
}

Powered by Google App Engine
This is Rietveld 408576698