components/bookmarks/browser/bookmark_utils.cc - Issue 1765993002: Remove UnescapeRule::URL_SPECIAL_CHARS from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_utils.cc

Issue 1765993002: Remove UnescapeRule::URL_SPECIAL_CHARS from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix, merge Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/auto_login_parser/auto_login_parser.cc ('K') | « components/auto_login_parser/auto_login_parser.cc ('k') | components/drive/service/fake_drive_service.cc » ('j') | components/drive/service/fake_drive_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_utils.cc

diff --git a/components/bookmarks/browser/bookmark_utils.cc b/components/bookmarks/browser/bookmark_utils.cc

index 0735df8a145e7dd252c5c1aa062d981c6c59a6af..164e9074462e8a47ad1fb18db66a44b068422cb8 100644

--- a/components/bookmarks/browser/bookmark_utils.cc

+++ b/components/bookmarks/browser/bookmark_utils.cc

@@ -527,8 +527,9 @@ base::string16 CleanUpUrlForMatching(

return base::i18n::ToLower(url_formatter::FormatUrlWithAdjustments(

GURL(TruncateUrl(gurl.spec())), languages,

url_formatter::kFormatUrlOmitUsernamePassword,

- net::UnescapeRule::SPACES | net::UnescapeRule::URL_SPECIAL_CHARS, NULL,

- NULL, adjustments ? adjustments : &tmp_adjustments));

+ net::UnescapeRule::SPACES | net::UnescapeRule::PATH_SEPARATORS |

+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS,

mmenke 2016/03/16 21:30:01 Looks safe - not used as a path. Note that unesca

+ nullptr, nullptr, adjustments ? adjustments : &tmp_adjustments));

}

base::string16 CleanUpTitleForMatching(const base::string16& title) {