components/password_manager/core/browser/affiliation_utils.cc - Issue 1765993002: Remove UnescapeRule::URL_SPECIAL_CHARS from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliation_utils.cc

Issue 1765993002: Remove UnescapeRule::URL_SPECIAL_CHARS from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/drive/service/fake_drive_service.cc ('k') | components/policy/core/common/cloud/device_management_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliation_utils.cc

diff --git a/components/password_manager/core/browser/affiliation_utils.cc b/components/password_manager/core/browser/affiliation_utils.cc

index 853edc528923524e8356a6b51775f7a89150eec6..b2997aa7aa0df49da90d55000184327ac14a2366 100644

--- a/components/password_manager/core/browser/affiliation_utils.cc

+++ b/components/password_manager/core/browser/affiliation_utils.cc

@@ -100,9 +100,11 @@ bool CanonicalizeHashComponent(const base::StringPiece& input_hash,

// safe" base64 alphabet; plus the padding ('=').

const char kBase64NonAlphanumericChars[] = "-_=";

- // We need net::UnescapeRule::URL_SPECIAL_CHARS to unescape the padding ('=').

+ // We need net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS to

+ // unescape the padding ('=').

std::string base64_encoded_hash = net::UnescapeURLComponent(

- input_hash.as_string(), net::UnescapeRule::URL_SPECIAL_CHARS);

+ input_hash.as_string(),

+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS);

if (!base64_encoded_hash.empty() &&

CanonicalizeBase64Padding(&base64_encoded_hash) &&