Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 1765933003: style: Rename the PseudoId enum values to CamelCase and prefix them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enum-clash-PseudoId: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.h
diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h
index 8f3aead06fe4530c62be831e7e50f0dac45de1c4..27d41b0ed14d1fa3755c3720976b1ae9b6807bd6 100644
--- a/third_party/WebKit/Source/core/dom/Node.h
+++ b/third_party/WebKit/Source/core/dom/Node.h
@@ -254,11 +254,11 @@ public:
bool isHTMLElement() const { return getFlag(IsHTMLFlag); }
bool isSVGElement() const { return getFlag(IsSVGFlag); }
- bool isPseudoElement() const { return getPseudoId() != NOPSEUDO; }
- bool isBeforePseudoElement() const { return getPseudoId() == BEFORE; }
- bool isAfterPseudoElement() const { return getPseudoId() == AFTER; }
- bool isFirstLetterPseudoElement() const { return getPseudoId() == FIRST_LETTER; }
- virtual PseudoId getPseudoId() const { return NOPSEUDO; }
+ bool isPseudoElement() const { return getPseudoId() != PseudoIdNoPseudo; }
+ bool isBeforePseudoElement() const { return getPseudoId() == PseudoIdBefore; }
+ bool isAfterPseudoElement() const { return getPseudoId() == PseudoIdAfter; }
+ bool isFirstLetterPseudoElement() const { return getPseudoId() == PseudoIdFirstLetter; }
+ virtual PseudoId getPseudoId() const { return PseudoIdNoPseudo; }
bool isCustomElement() const { return getFlag(CustomElementFlag); }
enum CustomElementState {
@@ -561,7 +561,7 @@ public:
const ComputedStyle& computedStyleRef() const;
- const ComputedStyle* ensureComputedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) { return virtualEnsureComputedStyle(pseudoElementSpecifier); }
+ const ComputedStyle* ensureComputedStyle(PseudoId pseudoElementSpecifier = PseudoIdNoPseudo) { return virtualEnsureComputedStyle(pseudoElementSpecifier); }
// -----------------------------------------------------------------------------
// Notification of document structure changes (see ContainerNode.h for more notification methods)
@@ -825,7 +825,7 @@ private:
virtual ComputedStyle* nonLayoutObjectComputedStyle() const { return nullptr; }
- virtual const ComputedStyle* virtualEnsureComputedStyle(PseudoId = NOPSEUDO);
+ virtual const ComputedStyle* virtualEnsureComputedStyle(PseudoId = PseudoIdNoPseudo);
void trackForDebugging();

Powered by Google App Engine
This is Rietveld 408576698