[compiler] Reduce the code size of the ToBoolean stub.

[compiler] Reduce the code size of the ToBoolean stub.

We effectively have 4 different cases to deal with, including the default, but on some platform where we emit the jump table inline (e.g. arm64) we end up emitting an unconditional jump to the same address 127 times.

BUG=

Committed: https://crrev.com/914c6c52a544e6834605da04597e36ad519022c4
Cr-Commit-Position: refs/heads/master@{#35859}

[epertoso, 2016-03-04 10:41:07]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 10:41:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765883002/1

[commit-bot: I haz the power, 2016-03-04 10:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 10:59:35]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-03-04 11:01:41]

Description was changed from

==========
[compiler] Reduce the code size of the ToBoolean stub.

We effectively have 4 cases (including the default), but on some arch where we
emit the jump table inline (e.g. arm64) we end up emitting an unconditional jump
to the same address 127 times.

BUG=
==========

to

==========
[compiler] Reduce the code size of the ToBoolean stub.

We effectively have 4 different cases to deal with, including the default, but
on some platform where we emit the jump table inline (e.g. arm64) we end up
emitting an unconditional jump to the same address 127 times.

BUG=
==========

[epertoso, 2016-03-04 11:01:41]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-04-21 18:04:13]

LGTM with comment.

https://codereview.chromium.org/1765883002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1765883002/diff/1/src/code-stubs.cc#newcode1631
src/code-stubs.cc:1631: assembler->Return(assembler->BooleanConstant(false));
You could even further reduce code size by having shared return_true and
return_false labels, now that we do automatic-edge-split-form.

[epertoso, 2016-04-28 11:58:08]

On 2016/04/21 at 18:04:13, bmeurer wrote:
> LGTM with comment.
> 
> https://codereview.chromium.org/1765883002/diff/1/src/code-stubs.cc
> File src/code-stubs.cc (right):
> 
>
https://codereview.chromium.org/1765883002/diff/1/src/code-stubs.cc#newcode1631
> src/code-stubs.cc:1631: assembler->Return(assembler->BooleanConstant(false));
> You could even further reduce code size by having shared return_true and
return_false labels, now that we do automatic-edge-split-form.

Done.

[epertoso, 2016-04-28 11:58:19]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-28 11:58:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1765883002/#ps20001
(title: "Update")

[commit-bot: I haz the power, 2016-04-28 11:58:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765883002/20001

[commit-bot: I haz the power, 2016-04-28 12:22:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-01 22:02:17]

Description was changed from

==========
[compiler] Reduce the code size of the ToBoolean stub.

We effectively have 4 different cases to deal with, including the default, but
on some platform where we emit the jump table inline (e.g. arm64) we end up
emitting an unconditional jump to the same address 127 times.

BUG=
==========

to

==========
[compiler] Reduce the code size of the ToBoolean stub.

We effectively have 4 different cases to deal with, including the default, but
on some platform where we emit the jump table inline (e.g. arm64) we end up
emitting an unconditional jump to the same address 127 times.

BUG=

Committed: https://crrev.com/914c6c52a544e6834605da04597e36ad519022c4
Cr-Commit-Position: refs/heads/master@{#35859}
==========

[commit-bot: I haz the power, 2016-05-01 22:02:18]

Patchset 2 (id:??) landed as
https://crrev.com/914c6c52a544e6834605da04597e36ad519022c4
Cr-Commit-Position: refs/heads/master@{#35859}