Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1765833002: Retire scoped_ptr_unittest.nc (Closed)

Created:
4 years, 9 months ago by tzik
Modified:
4 years, 9 months ago
Reviewers:
danakj, dcheng
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire scoped_ptr_unittest.nc scoped_ptr<> is now an alias of std::unique_ptr<> on Linux. So on Linux, the test is no longer needed in Chromium. Since no one seems to care the test on the other OSes than Linux, it's time to drop it. BUG=554298 Committed: https://crrev.com/13fb9a28c9d99e655fb1552a0aa2834e8f2069d9 Cr-Commit-Position: refs/heads/master@{#379454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -121 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D base/memory/scoped_ptr_unittest.nc View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tzik
PTAL
4 years, 9 months ago (2016-03-04 04:26:19 UTC) #3
dcheng
Seems reasonable to me. LGTM.
4 years, 9 months ago (2016-03-04 04:28:41 UTC) #4
danakj
RIP LGTM
4 years, 9 months ago (2016-03-04 19:37:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765833002/1
4 years, 9 months ago (2016-03-05 02:32:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 04:03:00 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 04:04:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13fb9a28c9d99e655fb1552a0aa2834e8f2069d9
Cr-Commit-Position: refs/heads/master@{#379454}

Powered by Google App Engine
This is Rietveld 408576698