Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: test/cctest/compiler/test-simplified-lowering.cc

Issue 1765823002: [compiler] Introduce code stubs for string relational comparisons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler/code-stub-assembler.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc b/test/cctest/compiler/test-simplified-lowering.cc
index dc790ff98aea27d583c980adc7d4ac31b2979a22..e72757cd36f0f9d41660d3d5f01538f40e081d7e 100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -1140,22 +1140,8 @@ TEST(LowerReferenceEqual_to_wordeq) {
t.CheckLoweringBinop(opcode, t.simplified()->ReferenceEqual(Type::Any()));
}
-
-TEST(LowerStringOps_to_call_and_compare) {
- // These tests need linkage for the calls.
- TestingGraph t(Type::String(), Type::String());
- IrOpcode::Value compare_lt =
- static_cast<IrOpcode::Value>(t.machine()->IntLessThan()->opcode());
- IrOpcode::Value compare_le = static_cast<IrOpcode::Value>(
- t.machine()->IntLessThanOrEqual()->opcode());
- t.CheckLoweringStringBinop(compare_lt, t.simplified()->StringLessThan());
- t.CheckLoweringStringBinop(compare_le,
- t.simplified()->StringLessThanOrEqual());
- }
-
-
- void CheckChangeInsertion(IrOpcode::Value expected, MachineType from,
- MachineType to, Type* type = Type::Any()) {
+void CheckChangeInsertion(IrOpcode::Value expected, MachineType from,
+ MachineType to, Type* type = Type::Any()) {
TestingGraph t(Type::Any());
Node* in = t.ExampleWithOutput(from);
NodeProperties::SetType(in, type);
@@ -1166,7 +1152,6 @@ TEST(LowerStringOps_to_call_and_compare) {
CHECK_EQ(in, use->InputAt(0)->InputAt(0));
}
-
TEST(InsertBasicChanges) {
CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, MachineType::Float64(),
MachineType::Int32(), Type::Signed32());
« src/compiler/code-stub-assembler.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698