Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 1765823002: [compiler] Introduce code stubs for string relational comparisons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/crankshaft/arm/lithium-codegen-arm.cc
diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc
index 31a0472fd562563e249c62639032ccb35f1d928d..99fe1bc3e5e6658e4cd6f1f6d01851bd6108a60b 100644
--- a/src/crankshaft/arm/lithium-codegen-arm.cc
+++ b/src/crankshaft/arm/lithium-codegen-arm.cc
@@ -2366,17 +2366,10 @@ void LCodeGen::DoStringCompareAndBranch(LStringCompareAndBranch* instr) {
DCHECK(ToRegister(instr->left()).is(r1));
DCHECK(ToRegister(instr->right()).is(r0));
- if (Token::IsOrderedRelationalCompareOp(instr->op())) {
- Handle<Code> code = CodeFactory::StringCompare(isolate()).code();
- CallCode(code, RelocInfo::CODE_TARGET, instr);
- __ cmp(r0, Operand::Zero());
- } else {
- Handle<Code> code = CodeFactory::StringEqual(isolate()).code();
- CallCode(code, RelocInfo::CODE_TARGET, instr);
- __ CompareRoot(r0, Heap::kTrueValueRootIndex);
- }
-
- EmitBranch(instr, ComputeCompareCondition(instr->op()));
+ Handle<Code> code = CodeFactory::StringCompare(isolate(), instr->op()).code();
+ CallCode(code, RelocInfo::CODE_TARGET, instr);
+ __ CompareRoot(r0, Heap::kTrueValueRootIndex);
+ EmitBranch(instr, eq);
}

Powered by Google App Engine
This is Rietveld 408576698