rewrite_to_chrome_style: Rewrite references to members through the class

rewrite_to_chrome_style: Rewrite references to members through the class

This catches references to members such as &ClassName::m_memberName to
rename the m_memberName correctly.

R=dcheng
BUG=584091
Committed: https://crrev.com/435df50496bb28a8b27a398a084174d53f9f4ae6
Cr-Commit-Position: refs/heads/master@{#379184}

[dcheng, 2016-03-04 01:41:55]

lgtm with a question. maybe just get rid of the narrowing bit of the matcher if
we don't need it (and I think we shouldn't)

https://codereview.chromium.org/1765783002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1765783002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:584:
unless(hasAncestor(functionDecl(internal_hack::isDefaulted())))));
I think we might not need this, cause the things you can default probably won't
reference the member like this, right? At least I can't think of a reason where
the compiler would synthesize something like this.

[danakj, 2016-03-04 01:55:51]

https://codereview.chromium.org/1765783002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1765783002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:584:
unless(hasAncestor(functionDecl(internal_hack::isDefaulted())))));
On 2016/03/04 01:41:55, dcheng wrote:
> I think we might not need this, cause the things you can default probably
won't
> reference the member like this, right? At least I can't think of a reason
where
> the compiler would synthesize something like this.

I couldn't think of it offhand, but then I thought who knows.. I can remove it
and we see if we get errors. Please try remember this, cuz I'll forget. :)

[danakj, 2016-03-04 01:57:15]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-04 01:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1765783002/#ps20001
(title: "rewrite-non-member-members: .")

[danakj, 2016-03-04 01:57:41]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-03-04 01:57:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765783002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765783002/1

[danakj, 2016-03-04 01:57:50]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-04 01:57:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1765783002/#ps40001
(title: "rewrite-non-member-members: .")

[commit-bot: I haz the power, 2016-03-04 01:58:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765783002/40001

[commit-bot: I haz the power, 2016-03-04 02:36:04]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-04 02:37:51]

Description was changed from

==========
rewrite_to_chrome_style: Rewrite references to members through the class

This catches references to members such as &ClassName::m_memberName to
rename the m_memberName correctly.

R=dcheng
BUG=584091
==========

to

==========
rewrite_to_chrome_style: Rewrite references to members through the class

This catches references to members such as &ClassName::m_memberName to
rename the m_memberName correctly.

R=dcheng
BUG=584091

Committed: https://crrev.com/435df50496bb28a8b27a398a084174d53f9f4ae6
Cr-Commit-Position: refs/heads/master@{#379184}
==========

[commit-bot: I haz the power, 2016-03-04 02:37:52]

Patchset 2 (id:??) landed as
https://crrev.com/435df50496bb28a8b27a398a084174d53f9f4ae6
Cr-Commit-Position: refs/heads/master@{#379184}