device/bluetooth/bluetooth_gatt_characteristic.h - Issue 1765773002: bluetooth: Refactor GetDescriptorForUUID to GetDescriptorsForUUID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_gatt_characteristic.h

Issue 1765773002: bluetooth: Refactor GetDescriptorForUUID to GetDescriptorsForUUID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bta-notify-tommyt-

Patch Set: GetDescriptorsForUUID split from other changes. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java ('K') | « device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java ('k') | device/bluetooth/bluetooth_gatt_characteristic.cc » ('j') | device/bluetooth/bluetooth_gatt_characteristic_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_gatt_characteristic.h

diff --git a/device/bluetooth/bluetooth_gatt_characteristic.h b/device/bluetooth/bluetooth_gatt_characteristic.h

index 489f59a56af8fb583df6dcdd2c1e4d5253f3327c..f10ec7cd29c66937365fa80d33b3cac075f9e63b 100644

--- a/device/bluetooth/bluetooth_gatt_characteristic.h

+++ b/device/bluetooth/bluetooth_gatt_characteristic.h

@@ -158,8 +158,10 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattCharacteristic {

virtual BluetoothGattDescriptor* GetDescriptor(

const std::string& identifier) const = 0;

- // Returns the GATT characteristic descriptor that matches |uuid|.

- virtual BluetoothGattDescriptor* GetDescriptorForUUID(

+ // Returns the GATT characteristic descriptors that match |uuid|. There may be

+ // multiple, as illustrated by Core Bluetooth Specification [V4.2 Vol 3 Part G

+ // 3.3.3.5 Characteristic Presentation Format].

+ std::vector<BluetoothGattDescriptor*> GetDescriptorsForUUID(

ortuno 2016/03/13 20:41:44 nit: Do you think GetDescriptorsByUUID or GetDescr

scheib 2016/03/25 00:13:57 Done: Renamed to GetDescriptorsByUUID.

const BluetoothUUID& uuid);

// Adds a characteristic descriptor to the locally hosted characteristic