Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5289)

Unified Diff: cc/scheduler/scheduler.h

Issue 1765723002: Hoist begin frame sources out of scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler_remove_throttle_flag
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source_unittest.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.h
diff --git a/cc/scheduler/scheduler.h b/cc/scheduler/scheduler.h
index a5a6bd473c06866c6e81938c2c6efc40f98dd96f..4828896194813409e3d607b8d07d1078ea4a5c52 100644
--- a/cc/scheduler/scheduler.h
+++ b/cc/scheduler/scheduler.h
@@ -60,7 +60,7 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
const SchedulerSettings& scheduler_settings,
int layer_tree_host_id,
base::SingleThreadTaskRunner* task_runner,
- BeginFrameSource* external_frame_source,
+ BeginFrameSource* begin_frame_source,
scoped_ptr<CompositorTimingHistory> compositor_timing_history);
~Scheduler() override;
@@ -73,8 +73,6 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
const SchedulerSettings& settings() const { return settings_; }
- void CommitVSyncParameters(base::TimeTicks timebase,
- base::TimeDelta interval);
void SetEstimatedParentDrawTime(base::TimeDelta draw_time);
void SetVisible(bool visible);
@@ -142,34 +140,26 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
void SetChildrenNeedBeginFrames(bool children_need_begin_frames);
void SetVideoNeedsBeginFrames(bool video_needs_begin_frames);
- void SetAuthoritativeVSyncInterval(const base::TimeDelta& interval);
-
protected:
Scheduler(SchedulerClient* client,
const SchedulerSettings& scheduler_settings,
int layer_tree_host_id,
base::SingleThreadTaskRunner* task_runner,
- BeginFrameSource* external_frame_source,
- scoped_ptr<SyntheticBeginFrameSource> synthetic_frame_source,
- scoped_ptr<BackToBackBeginFrameSource> unthrottled_frame_source,
+ BeginFrameSource* begin_frame_source,
scoped_ptr<CompositorTimingHistory> compositor_timing_history);
// Virtual for testing.
virtual base::TimeTicks Now() const;
const SchedulerSettings settings_;
+ // Not owned.
SchedulerClient* client_;
int layer_tree_host_id_;
base::SingleThreadTaskRunner* task_runner_;
- BeginFrameSource* external_frame_source_;
- scoped_ptr<SyntheticBeginFrameSource> synthetic_frame_source_;
- scoped_ptr<BackToBackBeginFrameSource> unthrottled_frame_source_;
-
- scoped_ptr<BeginFrameSourceMultiplexer> frame_source_;
- bool observing_frame_source_;
- base::TimeDelta authoritative_vsync_interval_;
- base::TimeTicks last_vsync_timebase_;
+ // Not owned.
+ BeginFrameSource* begin_frame_source_;
+ bool observing_begin_frame_source_;
scoped_ptr<CompositorTimingHistory> compositor_timing_history_;
base::TimeDelta estimated_parent_draw_time_;
@@ -224,14 +214,6 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
return inside_action_ == action;
}
- BeginFrameSource* primary_frame_source() {
- if (settings_.use_external_begin_frame_source) {
- DCHECK(external_frame_source_);
- return external_frame_source_;
- }
- return synthetic_frame_source_.get();
- }
-
base::WeakPtrFactory<Scheduler> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(Scheduler);
« no previous file with comments | « cc/scheduler/begin_frame_source_unittest.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698