Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1765713003: Reland "Speed up the LookupIterator" (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Speed up the LookupIterator" BUG= Committed: https://crrev.com/683223b4ba4857f4b3c44afffc3939e1dd22269d Cr-Commit-Position: refs/heads/master@{#34492}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : wrap in assertThrows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -167 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api-natives.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.h View 7 chunks +52 lines, -27 lines 0 comments Download
M src/lookup.cc View 1 17 chunks +132 lines, -108 lines 0 comments Download
M src/objects.h View 5 chunks +10 lines, -7 lines 0 comments Download
M src/objects.cc View 7 chunks +21 lines, -16 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/types.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/lookup-behind-property.js View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Toon Verwaest
ptal. The diff (+ test) is in patch 2
4 years, 9 months ago (2016-03-04 10:58:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765713003/20001
4 years, 9 months ago (2016-03-04 11:00:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765713003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765713003/40001
4 years, 9 months ago (2016-03-04 11:02:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 11:28:37 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 11:45:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765713003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765713003/40001
4 years, 9 months ago (2016-03-04 11:49:57 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-04 11:52:00 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 11:53:33 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/683223b4ba4857f4b3c44afffc3939e1dd22269d
Cr-Commit-Position: refs/heads/master@{#34492}

Powered by Google App Engine
This is Rietveld 408576698