Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1765703002: Update libvpx paths in libyuv (Closed)

Created:
4 years, 9 months ago by Johann
Modified:
4 years, 9 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Update libvpx paths in libyuv libvpx_new moved back to libvpx in https://codereview.chromium.org/1734613003/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M setup_links.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johann
Not sure I'm reading the OWNERS file correctly but I think you can approve this?
4 years, 9 months ago (2016-03-03 23:04:24 UTC) #2
kjellander_chromium
Yeah, and libyuv doesn't actually depend on libvpx if I'm not mistaken, these references just ...
4 years, 9 months ago (2016-03-04 09:03:39 UTC) #4
Johann
4 years, 9 months ago (2016-03-04 17:51:09 UTC) #5
Message was sent while issue was closed. 
On 2016/03/04 09:03:39, kjellander (chromium) wrote:
> Yeah, and libyuv doesn't actually depend on libvpx if I'm not mistaken, these
> references just exist since there are copied files from the WebRTC way of
> reusing the Chromium toolchain.
> I made similar CL at https://codereview.chromium.org/1764083002 that also
> includes the roll in the DEPS.
> 
> Closing this CL now.

Cool, thanks! Yeah, it didn't seem critical but I figured it should be kept in
line.

Powered by Google App Engine
This is Rietveld 408576698